Page MenuHomeFreeBSD

Modify sv_onexec hook to return error.
ClosedPublic

Authored by dchagin on Jun 26 2021, 10:19 AM.
Tags
None
Referenced Files
F102635595: D30911.diff
Fri, Nov 15, 3:31 AM
Unknown Object (File)
Oct 3 2024, 9:55 PM
Unknown Object (File)
Oct 3 2024, 6:21 PM
Unknown Object (File)
Oct 3 2024, 5:05 PM
Unknown Object (File)
Oct 3 2024, 12:54 AM
Unknown Object (File)
Oct 2 2024, 1:27 PM
Unknown Object (File)
Sep 27 2024, 5:40 PM
Unknown Object (File)
Sep 26 2024, 1:33 AM
Subscribers

Details

Summary

Temporary add stubs to the Linux emulation layer which calls the existing hook.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40118
Build 37007: arc lint + arc unit

Event Timeline

sys/kern/kern_exec.c
1155

At this point, error is KERN_SUCCESS, which is some Mach error code. We never assume that it has zero value. Please replace this fragment by e.g. the following

return (sv->sv_onexec != NULL ? sv->sv_onexec(p, imgp) : 0);

fixed, i missied that KERN_SUCCESS != 0

KERN_SUCCESS is 0, but it is undesirable to depend on that.

This revision is now accepted and ready to land.Jun 26 2021, 1:57 PM