Paths

Table of Contentst

Differential D30645

riscv: Rename pmap_fault_fixup() to pmap_fault()
ClosedPublic
Actions

Authored by markj on Jun 4 2021, 6:22 PM.

Tags

None

Referenced Files

	F97421727: D30645.diff
	Sun, Sep 29, 5:26 AM

	Unknown Object (File)
	Fri, Sep 27, 5:24 PM

	Unknown Object (File)
	Fri, Sep 27, 5:48 AM

	Unknown Object (File)
	Wed, Sep 18, 1:52 PM

	Unknown Object (File)
	Sun, Sep 8, 5:50 PM

	Unknown Object (File)
	Sun, Sep 8, 9:02 AM

	Unknown Object (File)
	Sun, Sep 8, 6:06 AM

	Unknown Object (File)
	Aug 15 2024, 5:33 PM

View All 35 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG317113bb1251: riscv: Rename pmap_fault_fixup() to pmap_fault()

Summary

This is consistent with other platforms, specifically arm and arm64,
which use it to implement software management of accessed and dirty
bits.

No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39713
Build 36602: arc lint + arc unit

Event Timeline

markj created this revision.Jun 4 2021, 6:22 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 4 2021, 6:22 PM

markj requested review of this revision.Jun 4 2021, 6:22 PM

markj added a parent revision: D30644: riscv: Handle hardware-managed dirty bit updates in pmap_promote_l2().

Harbormaster completed remote builds in B39713: Diff 90429.Jun 4 2021, 6:23 PM

markj added a reviewer: riscv.Jun 4 2021, 6:23 PM

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

jrtc27 accepted this revision.Jun 4 2021, 6:53 PM

This revision is now accepted and ready to land.Jun 4 2021, 6:53 PM

In D30645#688383, @jrtc27 wrote:

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

Ah, I see. Looks like last_fault_code can be removed then.

Regarding the overall change, I don't have a strong preference for it, it would just be nice to be consistent especially now that pmap-v4.c is gone.

In D30645#688386, @markj wrote:

In D30645#688383, @jrtc27 wrote:

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

Ah, I see. Looks like last_fault_code can be removed then.

Regarding the overall change, I don't have a strong preference for it, it would just be nice to be consistent especially now that pmap-v4.c is gone.

Yeah, seems sensible. I quite liked the "fixup" in the name, but best to align with pmap-v6 and arm64.

Closed by commit rG317113bb1251: riscv: Rename pmap_fault_fixup() to pmap_fault() (authored by markj). · Explain WhyJun 6 2021, 8:47 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG317113bb1251: riscv: Rename pmap_fault_fixup() to pmap_fault().

Revision Contents
Changeset List

Path

Size

sys/

riscv/

include/

2 lines

riscv/

2 lines

2 lines

Diff 90429

sys/riscv/include/pmap.h

Loading...

sys/riscv/riscv/pmap.c

Loading...

sys/riscv/riscv/trap.c

Loading...