Page MenuHomeFreeBSD
Differential D30645

riscv: Rename pmap_fault_fixup() to pmap_fault()
ClosedPublic
Actions

Authored by markj on Jun 4 2021, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 6:38 AM
Unknown Object (File)
Tue, Nov 5, 10:10 AM
Unknown Object (File)
Oct 14 2024, 5:33 PM
Unknown Object (File)
Oct 5 2024, 4:35 PM
Unknown Object (File)
Oct 5 2024, 11:38 AM
Unknown Object (File)
Oct 2 2024, 9:38 PM
Unknown Object (File)
Oct 2 2024, 7:13 PM
Unknown Object (File)
Oct 2 2024, 4:33 AM
View All 48 Files
Subscribers
imp
jrtc27

Details

Reviewers
jrtc27
Group Reviewers
riscv
Commits
rG317113bb1251: riscv: Rename pmap_fault_fixup() to pmap_fault()
Summary

This is consistent with other platforms, specifically arm and arm64,
which use it to implement software management of accessed and dirty
bits.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jun 4 2021, 6:22 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 4 2021, 6:22 PM
markj requested review of this revision.Jun 4 2021, 6:22 PM
markj added a parent revision: D30644: riscv: Handle hardware-managed dirty bit updates in pmap_promote_l2().
Harbormaster completed remote builds in B39713: Diff 90429.Jun 4 2021, 6:23 PM
markj added a reviewer: riscv.Jun 4 2021, 6:23 PM
jrtc27 added a subscriber: jrtc27.EditedJun 4 2021, 6:52 PM

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

jrtc27 accepted this revision.Jun 4 2021, 6:53 PM
This revision is now accepted and ready to land.Jun 4 2021, 6:53 PM
markj added a comment.Jun 4 2021, 6:55 PM
In D30645#688383, @jrtc27 wrote:

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

Ah, I see. Looks like last_fault_code can be removed then.

Regarding the overall change, I don't have a strong preference for it, it would just be nice to be consistent especially now that pmap-v4.c is gone.

jrtc27 added a comment.Jun 4 2021, 6:56 PM
In D30645#688386, @markj wrote:
In D30645#688383, @jrtc27 wrote:

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

Ah, I see. Looks like last_fault_code can be removed then.

Regarding the overall change, I don't have a strong preference for it, it would just be nice to be consistent especially now that pmap-v4.c is gone.

Yeah, seems sensible. I quite liked the "fixup" in the name, but best to align with pmap-v6 and arm64.

Closed by commit rG317113bb1251: riscv: Rename pmap_fault_fixup() to pmap_fault() (authored by markj). · Explain WhyJun 6 2021, 8:47 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG317113bb1251: riscv: Rename pmap_fault_fixup() to pmap_fault().

Revision Contents
Changeset List

PathSize
sys/
riscv/
include/
2 lines
riscv/
2 lines
2 lines

Diff 90497

View Options

sys/riscv/include/pmap.h

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...
View Options

sys/riscv/riscv/trap.c

Loading...