Page MenuHomeFreeBSD
Differential D30043

tcp: Whitespace cleanup in brr and rack
ClosedPublic
Actions

Authored by rscheff on Apr 30 2021, 10:12 AM.
Tags
None
Referenced Files
F102913906: D30043.diff
Mon, Nov 18, 4:42 PM
F102869098: D30043.id103255.diff
Mon, Nov 18, 5:33 AM
Unknown Object (File)
Sat, Nov 16, 2:25 AM
Unknown Object (File)
Thu, Nov 14, 9:27 AM
Unknown Object (File)
Fri, Nov 8, 8:10 AM
Unknown Object (File)
Tue, Nov 5, 7:59 PM
Unknown Object (File)
Tue, Nov 5, 12:06 PM
Unknown Object (File)
Tue, Nov 5, 8:10 AM
View All Files
Subscribers
glebius
imp
melifaro
rgrimes
thj

Details

Reviewers
rrs
jtl
tuexen
kbowling
thj
Group Reviewers
transport
Commits
rG033718abc859: tcp: Whitespace cleanup in brr and rack
Summary

Whitespace cleanup (leading spaces to tabs)
Nicefy function definitions

No functional change

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38930
Build 35819: arc lint + arc unit

Event Timeline

rscheff created this revision.Apr 30 2021, 10:12 AM
Herald added a reviewer: transport. · View Herald TranscriptApr 30 2021, 10:12 AM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Apr 30 2021, 10:12 AM
Harbormaster completed remote builds in B38930: Diff 88410.Apr 30 2021, 10:12 AM
rrs added a comment.Apr 30 2021, 6:25 PM

Richard

Please wait. I have a major set of changes coming in and this is old broken code you are playing with. I am sure
a lot of the spacings are taken care of . Please wait until D30036 lands before you do any cleanups.

rrs requested changes to this revision.Apr 30 2021, 6:25 PM
This revision now requires changes to proceed.Apr 30 2021, 6:25 PM
rscheff added a comment.Apr 30 2021, 6:28 PM

Certainly. While fixing the socket buffer upcall / SACK interaction (29290) the large swath of missing tabs got on me :)

rgrimes added a subscriber: rgrimes.May 3 2021, 6:16 PM

The adding of blank lines between all the forward declarations seems wrong to me.

rscheff abandoned this revision.Jun 16 2021, 9:26 AM
rscheff updated this revision to Diff 103254.Feb 26 2022, 2:57 PM
  • update whitespace fixes
Herald added a subscriber: glebius. · View Herald TranscriptFeb 26 2022, 2:57 PM
Harbormaster completed remote builds in B44584: Diff 103254.Feb 26 2022, 2:57 PM
rscheff updated this revision to Diff 103255.Feb 26 2022, 3:00 PM
  • cleaning up forward declarations
Harbormaster completed remote builds in B44585: Diff 103255.Feb 26 2022, 3:00 PM
thj accepted this revision.Apr 13 2022, 9:16 AM
thj added a subscriber: thj.

I don't see any functional changes and rrs blocking review has landed, so this looks fine to land to me.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2022, 1:31 PM
Closed by commit rG033718abc859: tcp: Whitespace cleanup in brr and rack (authored by rscheff). · Explain Why
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG033718abc859: tcp: Whitespace cleanup in brr and rack.

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
96 lines
72 lines
4 lines

Diff 88410

View Options

sys/netinet/tcp_stacks/bbr.c

Loading...
View Options

sys/netinet/tcp_stacks/rack.c

Loading...
View Options

sys/netinet/tcp_stacks/tcp_bbr.h

Loading...