tcp: Whitespace cleanup in brr and rack
ClosedPublic
Actions

Authored by rscheff on Apr 30 2021, 10:12 AM.

Details

Reviewers

rrs
jtl
tuexen
kbowling
thj

Group Reviewers

transport

Commits

rG033718abc859: tcp: Whitespace cleanup in brr and rack

Summary

Whitespace cleanup (leading spaces to tabs)
Nicefy function definitions

No functional change

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44584
Build 41472: arc lint + arc unit

Event Timeline

rscheff created this revision.Apr 30 2021, 10:12 AM

Herald added a reviewer: transport. · View Herald TranscriptApr 30 2021, 10:12 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Apr 30 2021, 10:12 AM

Harbormaster completed remote builds in B38930: Diff 88410.Apr 30 2021, 10:12 AM

Richard

Please wait. I have a major set of changes coming in and this is old broken code you are playing with. I am sure
a lot of the spacings are taken care of . Please wait until D30036 lands before you do any cleanups.

rrs requested changes to this revision.Apr 30 2021, 6:25 PM

This revision now requires changes to proceed.Apr 30 2021, 6:25 PM

Certainly. While fixing the socket buffer upcall / SACK interaction (29290) the large swath of missing tabs got on me :)

The adding of blank lines between all the forward declarations seems wrong to me.

rscheff abandoned this revision.Jun 16 2021, 9:26 AM

update whitespace fixes

Herald added a subscriber: glebius. · View Herald TranscriptFeb 26 2022, 2:57 PM

Harbormaster completed remote builds in B44584: Diff 103254.Feb 26 2022, 2:57 PM

cleaning up forward declarations

Harbormaster completed remote builds in B44585: Diff 103255.Feb 26 2022, 3:00 PM

I don't see any functional changes and rrs blocking review has landed, so this looks fine to land to me.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 13 2022, 1:31 PM

Closed by commit rG033718abc859: tcp: Whitespace cleanup in brr and rack (authored by rscheff). · Explain Why

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG033718abc859: tcp: Whitespace cleanup in brr and rack.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

bbr.c

85 lines

Diff 103254

View Options

sys/netinet/tcp_stacks/bbr.c

tcp: Whitespace cleanup in brr and rackClosedPublicActions