Page MenuHomeFreeBSD

Remove PCPU_INC
ClosedPublic

Authored by jah on Mar 17 2021, 1:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 7:16 AM
Unknown Object (File)
Thu, Oct 17, 7:04 AM
Unknown Object (File)
Oct 12 2024, 9:19 PM
Unknown Object (File)
Oct 12 2024, 9:19 PM
Unknown Object (File)
Oct 12 2024, 9:19 PM
Unknown Object (File)
Oct 12 2024, 9:00 PM
Unknown Object (File)
Oct 10 2024, 7:21 AM
Unknown Object (File)
Oct 6 2024, 8:57 PM

Details

Summary

e4b8deb22227 removed the last in-tree uses of PCPU_INC(). Its
potential benefit is also practically nonexistent. Non-x86
platforms already implement it as PCPU_ADD(..., 1), and according
to [0] there are no recent x86 processors for which the 'inc'
instruction provides a performance benefit over the equivalent
memory-operand form of the 'add' instruction. The only remaining
benefit of 'inc' is smaller instruction size, which in this case
is inconsequential given the limited number of per-CPU data consumers.

[0]: https://www.agner.org/optimize/instruction_tables.pdf

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37890
Build 34779: arc lint + arc unit

Event Timeline

jah requested review of this revision.Mar 17 2021, 1:25 AM
This revision is now accepted and ready to land.Mar 17 2021, 8:35 PM
This revision was automatically updated to reflect the committed changes.