Page MenuHomeFreeBSD

Remove PCPU_INC
ClosedPublic

Authored by jah on Mar 17 2021, 1:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 3:30 AM
Unknown Object (File)
Mon, Jan 20, 5:19 PM
Unknown Object (File)
Fri, Jan 17, 5:17 PM
Unknown Object (File)
Fri, Jan 17, 2:48 PM
Unknown Object (File)
Jan 12 2025, 10:32 PM
Unknown Object (File)
Jan 12 2025, 10:26 PM
Unknown Object (File)
Jan 12 2025, 3:45 PM
Unknown Object (File)
Jan 5 2025, 12:47 PM

Details

Summary

e4b8deb22227 removed the last in-tree uses of PCPU_INC(). Its
potential benefit is also practically nonexistent. Non-x86
platforms already implement it as PCPU_ADD(..., 1), and according
to [0] there are no recent x86 processors for which the 'inc'
instruction provides a performance benefit over the equivalent
memory-operand form of the 'add' instruction. The only remaining
benefit of 'inc' is smaller instruction size, which in this case
is inconsequential given the limited number of per-CPU data consumers.

[0]: https://www.agner.org/optimize/instruction_tables.pdf

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jah requested review of this revision.Mar 17 2021, 1:25 AM
This revision is now accepted and ready to land.Mar 17 2021, 8:35 PM
This revision was automatically updated to reflect the committed changes.