Page MenuHomeFreeBSD
Differential D28749

ipmi_ssif: Fix inverted for the end of multi-part reads
ClosedPublic
Actions

Authored by allanjude on Feb 17 2021, 9:35 PM.
Tags
None
Referenced Files
F108488587: D28749.diff
Sat, Jan 25, 11:55 AM
Unknown Object (File)
Sat, Jan 11, 8:02 AM
Unknown Object (File)
Fri, Jan 10, 4:41 PM
Unknown Object (File)
Nov 20 2024, 9:01 AM
Unknown Object (File)
Nov 13 2024, 9:15 PM
Unknown Object (File)
Oct 2 2024, 9:13 PM
Unknown Object (File)
Oct 1 2024, 5:30 AM
Unknown Object (File)
Sep 26 2024, 4:01 PM
View All 71 Files
Subscribers
imp
manu

Details

Reviewers
scottph
manu
Commits
rG8c280db0b4d2: ipmi_ssif: Fix inverted for the end of multi-part reads
Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37124
Build 34013: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:35 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 9:35 PM
allanjude requested review of this revision.Feb 17 2021, 9:35 PM
Harbormaster completed remote builds in B37124: Diff 84144.Feb 17 2021, 9:35 PM
allanjude added a parent revision: D28748: ig4(4): Use calculated value when sda_hold is zero in ACPI.Feb 17 2021, 9:35 PM
allanjude added a child revision: D28750: ipmi: on aarch64, load dependancies to increase chance of finding ipmi device.
allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM
manu added a subscriber: manu.Feb 17 2021, 10:28 PM

Any docs on what this should contain ?

allanjude added a reviewer: scottph.Feb 17 2021, 11:01 PM
In D28749#643720, @manu wrote:

Any docs on what this should contain ?

I think specifically this one 0xff indicates 'last block, no more entries', and the logic was accidently inverted before.

scottph added a comment.Feb 17 2021, 11:05 PM

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

manu accepted this revision.Feb 17 2021, 11:24 PM
In D28749#643844, @scottph wrote:

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

Thanks, that was exactly what I was looking for.

This revision is now accepted and ready to land.Feb 17 2021, 11:24 PM
allanjude added a comment.Feb 18 2021, 1:47 AM

Do we want to put this link and section reference in the commit message?

manu added a comment.Feb 18 2021, 8:31 AM
In D28749#643982, @allanjude wrote:

Do we want to put this link and section reference in the commit message?

I'm not a fan of putting links as they tend to disappear over time but citing the name of the doc and chapter would be nice to do.

Closed by commit rG8c280db0b4d2: ipmi_ssif: Fix inverted for the end of multi-part reads (authored by allanjude). · Explain WhyFeb 18 2021, 3:51 PM
This revision was automatically updated to reflect the committed changes.
allanjude added a commit: rG8c280db0b4d2: ipmi_ssif: Fix inverted for the end of multi-part reads.

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
2 lines

Diff 84144

View Options

sys/dev/ipmi/ipmi_ssif.c

Loading...