smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
ClosedPublic
Actions

sys/dev/smbios/smbios.c
119	Should take the opportunity of updating this files to add defines for the table length instead of using magic numbers here ?
124	Same here
145	And same here.

allanjude mentioned this in D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.Feb 23 2021, 10:50 PM

gallatin mentioned this in D42592: smbios: handle smbios3 for arm64.Nov 14 2023, 12:40 AM

gallatin mentioned this in rGba0e4d7971e0: smbios: handle smbios3 for arm64.Nov 15 2023, 4:50 PM

This has all been committed. Commandeering Revision to close it.

Again, if there's something I've overlooked, a please open new differential and tag me and I'll look into it.

imp accepted this revision.Jun 27 2024, 9:28 PM

This revision is now accepted and ready to land.Jun 27 2024, 9:28 PM

Looks like Drew already landed this:

commit ba0e4d7971e05ee64281a4fc49a2fb408c8ad816
Author: Andrew Gallatin <gallatin@FreeBSD.org>
Date:   Wed Nov 15 11:11:53 2023 -0500

    smbios: handle smbios3 for arm64

    Get smbios working on arm64 where it seems to be
    exclusively smbios version 3.x

    The "interesting" thing here is that the smbios table seems to be
    RAM in the EFI runtime services table. This makes it owned by "ram0",
    and not io memory. That prevents bus_alloc_resource() from being able
    to claim it, since ram0 already owns it. According to jhb, this is
    how things are supposed to work.  Eg, bus_alloc_resource() is meant
    to be used with IO memory, not physical memory.  Following his
    suggestion, I converted the driver to simply use pmap_mapbios().

    This is a prerequisite for getting IPMI to attach via the SSIF
    attachment on arm64 servers, where all IPMI that I've seen
    uses SSIF.

    Note that this change is based on initial work by Allan Jude in
    https://reviews.freebsd.org/D28739.

    Reviewed by: imp
    Sponsored by: Netflix, Ampere Computing LLC (D28739)
    Differential Revision: https://reviews.freebsd.org/D42592

imp closed this revision.Jun 27 2024, 9:29 PM