Page MenuHomeFreeBSD
Differential D28740

smbios: Use loader provided address for SMBIOS entry point
ClosedPublic
Actions

Authored by imp on Feb 17 2021, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 22, 6:03 PM
Unknown Object (File)
Sun, Sep 22, 9:10 AM
Unknown Object (File)
Sat, Sep 21, 2:00 PM
Unknown Object (File)
Sat, Sep 21, 6:00 AM
Unknown Object (File)
Fri, Sep 20, 1:21 AM
Unknown Object (File)
Thu, Sep 19, 9:51 AM
Unknown Object (File)
Tue, Sep 17, 1:10 PM
Unknown Object (File)
Mon, Sep 9, 2:02 AM
View All 38 Files
Subscribers
imp

Details

Reviewers
allanjude
imp
Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37115
Build 34004: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:34 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 9:34 PM
allanjude requested review of this revision.Feb 17 2021, 9:34 PM
allanjude added a parent revision: D28739: smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
allanjude added a child revision: D28741: acpi: Add workaround for Altra I2C memory resource.
Harbormaster completed remote builds in B37115: Diff 84135.Feb 17 2021, 9:35 PM
allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM
imp accepted this revision.Feb 17 2021, 11:19 PM

Thanks for the split. This one looks good...

This revision is now accepted and ready to land.Feb 17 2021, 11:19 PM
allanjude retitled this revision from smbios: Use loader provided adddress for SMBIOS entry point to smbios: Use loader provided address for SMBIOS entry point.Feb 24 2021, 2:51 PM
imp commandeered this revision.Jun 27 2024, 9:33 PM
imp edited reviewers, added: allanjude; removed: imp.

This review is OBE. Other changes implement this in main.

This revision now requires review to proceed.Jun 27 2024, 9:33 PM
imp accepted this revision.Jun 27 2024, 9:33 PM
This revision is now accepted and ready to land.Jun 27 2024, 9:33 PM
imp closed this revision.Jun 27 2024, 9:35 PM

This revision by Val Packett implements this functionality in a better way.
If I've missed something, please let me know, file a new differential, tag me, etc

commit a29bff7a5216bd5f4a76228788e7eacf235004de
Author: Val Packett <val@packett.cool>
Date:   Wed Apr 7 14:46:29 2021 -0500

    smbios: support getting address from EFI

    On some systems (e.g. Lenovo ThinkPad X240, Apple MacBookPro12,1)
    the SMBIOS entry point is not found in the <0xFFFFF space.

    Follow the SMBIOS spec and use the EFI Configuration Table for
    locating the entry point on EFI systems.

    Reviewed by:    rpokala, dab
    MFC after:      1 week
    Sponsored by:   Dell EMC Isilon
    Differential Revision:  https://reviews.freebsd.org/D29276

Revision Contents
Changeset List

PathSize
sys/
dev/
smbios/
20 lines

Diff 84135

View Options

sys/dev/smbios/smbios.c

Loading...