Differential D28213

Reuse the amd64 loader relocation code on arm64
ClosedPublic
Actions

Authored by andrew on Jan 17 2021, 6:22 PM.

Details

Reviewers

kib

Group Reviewers

arm64

Commits

rGf6f0b849fb26: Reuse the amd64 loader relocation code on arm64

Summary

There is no need to keep multiple copies of the relocation code. The
amd64 code works on arm64 with a few small changes to relocation types.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36300
Build 33189: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 17 2021, 6:22 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 17 2021, 6:22 PM

andrew requested review of this revision.Jan 17 2021, 6:22 PM

Harbormaster completed remote builds in B36300: Diff 82432.Jan 17 2021, 6:22 PM

I must admit it is a weird source before the change. IMO we should split this code into per-arch file/function, not merge arches.

But I do not deal with this code, so this is only an opinion.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2021, 6:33 PM

Closed by commit rGf6f0b849fb26: Reuse the amd64 loader relocation code on arm64 (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGf6f0b849fb26: Reuse the amd64 loader relocation code on arm64.

Revision Contents
Changeset List

Path

Size

stand/

common/

reloc_elf.c

35 lines

Diff 82432

View Options

Reuse the amd64 loader relocation code on arm64ClosedPublicActions