Page MenuHomeFreeBSD
Differential D27830

Add SoC audio framework
ClosedPublic
Actions

Authored by gonzo on Dec 30 2020, 12:20 AM.
Tags
None
Referenced Files
F102635374: D27830.diff
Fri, Nov 15, 3:26 AM
Unknown Object (File)
Tue, Nov 5, 2:40 AM
Unknown Object (File)
Oct 14 2024, 9:18 PM
Unknown Object (File)
Oct 8 2024, 4:50 PM
Unknown Object (File)
Oct 3 2024, 1:11 AM
Unknown Object (File)
Oct 2 2024, 11:53 PM
Unknown Object (File)
Oct 2 2024, 7:25 PM
Unknown Object (File)
Oct 1 2024, 2:01 PM
View All 88 Files
Subscribers
andrew
avg
emaste
gbe
• hselasky
imp

Details

Reviewers
manu
Commits
rGcb25a9455802: arm64: allwinner: Add i2s and codec support
rG2cfe870acdec: arm64: Add Soc audio framework
Summary

This framework is initial implementation of the simple-audio-card compatible
audio driver framework. It provides glue for CPU/codec/aux device.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35772
Build 32661: arc lint + arc unit

Event Timeline

gonzo created this revision.Dec 30 2020, 12:20 AM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptDec 30 2020, 12:20 AM
gonzo requested review of this revision.Dec 30 2020, 12:20 AM
Harbormaster completed remote builds in B35772: Diff 81346.Dec 30 2020, 12:20 AM
gbe added a subscriber: gbe.Dec 30 2020, 8:51 AM
manu added a comment.Dec 30 2020, 9:32 AM

Looks nice to me, do you have some example drivers so it might be easier to review ?

sys/dev/sound/fdt/simple_amplifier.c
98

enable-gpios is optional.

gonzo updated this revision to Diff 81382.Dec 30 2020, 7:33 PM
  • Add Allwinner codecs and I2S driver as an example for the framework usage
  • simple-amplifier: make gpio-enable optional
Harbormaster completed remote builds in B35799: Diff 81382.Dec 30 2020, 7:33 PM
manu added a comment.Dec 31 2020, 10:46 AM

Thanks for the example driver.
This looks ok for me but I know almost nothing about sound :P

sys/arm/allwinner/aw_i2s.c
339 ↗(On Diff #81382)

Not sure this is correct :)

• hselasky added a subscriber: • hselasky.Jan 11 2021, 8:39 AM

I'd like to review this.

avg added a subscriber: avg.Jun 4 2021, 11:47 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 11 2021, 7:07 PM
Closed by commit rG2cfe870acdec: arm64: Add Soc audio framework (authored by gonzo, committed by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG2cfe870acdec: arm64: Add Soc audio framework.
manu added a commit: rGcb25a9455802: arm64: allwinner: Add i2s and codec support.

Revision Contents
Changeset List

PathSize
sys/
conf/
4 lines
dev/
sound/
fdt/
72 lines
95 lines
546 lines
127 lines
201 lines

Diff 81346

View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/sound/fdt/audio_dai.h

Loading...
View Options

sys/dev/sound/fdt/audio_dai_if.m

Loading...
View Options

sys/dev/sound/fdt/audio_soc.c

Loading...
View Options

sys/dev/sound/fdt/dummy_codec.c

Loading...
View Options

sys/dev/sound/fdt/simple_amplifier.c

Loading...