Remove gzip'ed a.out support.
ClosedPublic
Actions

Authored by delphij on Jul 29 2019, 6:45 AM.

Details

Reviewers

imp
phk
ota_j.email.ne.jp
emaste
kib

Commits

rS350436: Remove gzip'ed a.out support.

Summary

Remove gzip'ed a.out support.

The current implementation of gzipped a.out support was based
on a very old version of InfoZIP which ships with an ancient
modified version of zlib, and was removed from the GENERIC
kernel in 1999 when we moved to an ELF world.

PR: 205822

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25560
Build 24168: arc lint + arc unit

Event Timeline

delphij created this revision.Jul 29 2019, 6:45 AM

Herald added a subscriber: andrew. · View Herald TranscriptJul 29 2019, 6:45 AM

Harbormaster completed remote builds in B25560: Diff 60226.Jul 29 2019, 6:45 AM

delphij added reviewers: ota_j.email.ne.jp, emaste.Jul 29 2019, 6:45 AM

The changes look okay.

Should we ask kib to review as well?
I recall he had strong motivation keeping a.out executable format support although he didn't seem to much care about gzip'ed a.out.

+kib@

Fine with me

It's my belief this hasn't worked in a long time. Maybe not since at least FreeBSD 4 or 5 (or maybe even 3 when it was retired). I've seen reports since 6 that it's broken.

This revision is now accepted and ready to land.Jul 30 2019, 3:17 AM

kib accepted this revision.Jul 30 2019, 5:04 AM

Closed by commit rS350436: Remove gzip'ed a.out support. (authored by delphij). · Explain WhyJul 30 2019, 5:13 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS350436: Remove gzip'ed a.out support..

Someone mentioned https://svnweb.freebsd.org/base?view=revision&revision=231885 was trigger in one of the mailing list. Anyway, if that's true, it's been broken for 7 years.

ota_j.email.ne.jp mentioned this in D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..Jul 30 2019, 10:49 PM

jrtc27 mentioned this in D24910: Add macros simplifying the fake preload setup.May 21 2020, 6:00 PM