Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25119 Build 23817: arc lint + arc unit
Event Timeline
sys/amd64/amd64/minidump_machdep.c | ||
---|---|---|
453 | We traditionally use %ju/cast to uintmax_t for large values. Also, would it make sense to round instead of truncating ? |
sys/amd64/amd64/minidump_machdep.c | ||
---|---|---|
453 | Both valid points. But minidumpsys already has a %llu printf with (long long)dumpsize >> 20 and I thought it better to stay consistent with existing code. |
Comment Actions
Anyway, do as you want. Printing any estimation of the size in case of failure is an improvement on its own, even if not perfect.
sys/amd64/amd64/minidump_machdep.c | ||
---|---|---|
345 | If you look closer, the formats usage is not consistent, one case uses %llu, another %ju. You may fix %llu case while there. |