Page MenuHomeFreeBSD

Display the approximate space needed when a minidump fails due to lack of space.
ClosedPublic

Authored by np on Jun 29 2019, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 9 2024, 1:40 PM
Unknown Object (File)
Oct 31 2024, 7:22 AM
Unknown Object (File)
Oct 28 2024, 10:39 PM
Unknown Object (File)
Oct 3 2024, 3:52 AM
Unknown Object (File)
Sep 28 2024, 11:10 AM
Unknown Object (File)
Sep 24 2024, 3:45 AM
Unknown Object (File)
Sep 8 2024, 3:17 AM
Unknown Object (File)
Sep 7 2024, 3:05 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25119
Build 23817: arc lint + arc unit

Event Timeline

sys/amd64/amd64/minidump_machdep.c
453

We traditionally use %ju/cast to uintmax_t for large values.

Also, would it make sense to round instead of truncating ?

sys/amd64/amd64/minidump_machdep.c
453

Both valid points. But minidumpsys already has a %llu printf with (long long)dumpsize >> 20 and I thought it better to stay consistent with existing code.

Anyway, do as you want. Printing any estimation of the size in case of failure is an improvement on its own, even if not perfect.

sys/amd64/amd64/minidump_machdep.c
345

If you look closer, the formats usage is not consistent, one case uses %llu, another %ju. You may fix %llu case while there.

This revision is now accepted and ready to land.Jun 29 2019, 7:19 PM