HomeFreeBSD
Diffusion FreeBSD src repository bafaa70b6f90

libc __sfvwrite(): roll back FILE buffer pointer on fflush error
bafaa70b6f90
Actions

Description

libc __sfvwrite(): roll back FILE buffer pointer on fflush error

__sfvwrite() advances the pointer before calling fflush. If fflush()
fails, it is not enough to roll back inside it, because we cannot know
how much was advanced by the caller.

Reported by: Peter <pmc@citylink.dinoex.sub.org>
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Fixes: 86a16ada1ea608408cec370171d9f59353e97c77

Details

Provenance
kibAuthored on Mar 6 2022, 8:59 AM
markjCommitted on Mar 6 2022, 3:29 PM
Parents
rG1fb00c8f1060: buf_alloc(): Stop using LK_NOWAIT, use LK_NOWITNESS
Branches
Unknown
Tags
Unknown
Reverted By
rG0b7939d725ba: fflush: correct buffer handling in __sflush
rGd2c65a1c9486: fflush: correct buffer handling in __sflush
rG4e0e01bf6511: fflush: correct buffer handling in __sflush
D42491: fflush: correct buffer handling in __sflush

Event Timeline

markj committed rGbafaa70b6f90: libc __sfvwrite(): roll back FILE buffer pointer on fflush error (authored by kib).Mar 6 2022, 3:29 PM
markj mentioned this in rG647f02d68a60: libc __sfvwrite(): roll back FILE buffer pointer on fflush error.Mar 14 2022, 2:11 PM
markj mentioned this in rG626c1423ee93: libc __sfvwrite(): roll back FILE buffer pointer on fflush error.Mar 14 2022, 3:49 PM
markj mentioned this in rG6e13794fbe6e: libc: Restore fp state upon flush error in fputc.Mar 28 2022, 3:25 PM
markj mentioned this in rG7be0c792c46c: libc: Restore fp state upon flush error in fputc.Mar 31 2022, 3:33 PM
markj mentioned this in rG3ca78fba9653: libc: Restore fp state upon flush error in fputc.Mar 31 2022, 3:57 PM
kib mentioned this in D36427: libc/stdio: only rollback FILE state back on EINTR.Sep 2 2022, 2:21 PM
emaste added a reverting change: D42491: fflush: correct buffer handling in __sflush.Nov 7 2023, 2:56 PM
emaste added a reverting change: rG4e0e01bf6511: fflush: correct buffer handling in __sflush.Nov 7 2023, 5:28 PM
emaste added a reverting change: rGd2c65a1c9486: fflush: correct buffer handling in __sflush.Nov 7 2023, 5:59 PM
emaste added a reverting change: rG0b7939d725ba: fflush: correct buffer handling in __sflush.Nov 7 2023, 6:45 PM

Changes (1)

PathSize
lib/
libc/
stdio/

rGbafaa70b6f90

View Options

lib/libc/stdio/fvwrite.c

Loading...