Page MenuHomeFreeBSD

fflush: correct buffer handling in __sflush
ClosedPublic

Authored by emaste on Nov 7 2023, 2:56 PM.
Tags
None
Referenced Files
F102079032: D42491.id.diff
Thu, Nov 7, 8:55 AM
Unknown Object (File)
Wed, Nov 6, 11:08 PM
Unknown Object (File)
Tue, Nov 5, 12:54 PM
Unknown Object (File)
Mon, Oct 21, 3:00 AM
Unknown Object (File)
Wed, Oct 16, 6:50 PM
Unknown Object (File)
Wed, Oct 16, 5:19 PM
Unknown Object (File)
Wed, Oct 16, 5:13 PM
Unknown Object (File)
Tue, Oct 15, 4:40 AM
Subscribers

Details

Summary
Two additional stdio changes followed 86a16ada1ea6 and need to be
reverted as part of the fflush fix.

This reverts commit 6e13794fbe6e82c21365d0fd66769bf8b19c0197.
This reverts commit bafaa70b6f9098d83d074968c8e6747ecec1e118.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 7 2023, 2:56 PM
emaste created this revision.

With this change there are only trivial differences between stable/12, stable/13, stable/14, and main in the three affected files
lib/libc/stdio/fflush.c
lib/libc/stdio/fvwrite.c
lib/libc/stdio/wbuf.c.

Changes are $FreeBSD$ removal and a style change (if (__fflush(fp) != 0) vs if (__fflush(fp))).
(also a leftover #include of errno.h which was missed in the revert)

This revision is now accepted and ready to land.Nov 7 2023, 4:02 PM
This revision was automatically updated to reflect the committed changes.