Differential D45041

sysctl: Make sysctl_ctx_free() a bit safer
ClosedPublic
Actions

Authored by markj on Wed, May 1, 12:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 5:39 PM

	Unknown Object (File)
	Fri, May 3, 7:43 PM

	Unknown Object (File)
	Thu, May 2, 6:39 PM

	Unknown Object (File)
	Thu, May 2, 6:39 PM

	Unknown Object (File)
	Thu, May 2, 2:37 PM

Subscribers

Details

Reviewers

thj
emaste

Commits

rG24268f262b41: sysctl: Make sysctl_ctx_free() a bit safer
rGd5eae57088f5: sysctl: Make sysctl_ctx_free() a bit safer

Summary

Clear the list before returning so that it's idempotent when it
succeeds.

While here, use TAILQ_FOREACH_SAFE in the loop which unregisters OIDs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Wed, May 1, 12:00 PM

Herald added subscribers: olce, imp. · View Herald TranscriptWed, May 1, 12:00 PM

markj requested review of this revision.Wed, May 1, 12:00 PM

Harbormaster completed remote builds in B57494: Diff 137940.Wed, May 1, 12:00 PM

thj accepted this revision.Wed, May 1, 12:03 PM

This revision is now accepted and ready to land.Wed, May 1, 12:03 PM

emaste accepted this revision.Wed, May 1, 12:13 PM

Closed by commit rGd5eae57088f5: sysctl: Make sysctl_ctx_free() a bit safer (authored by markj). · Explain WhyThu, May 2, 8:02 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd5eae57088f5: sysctl: Make sysctl_ctx_free() a bit safer.

markj added a commit: rG24268f262b41: sysctl: Make sysctl_ctx_free() a bit safer.Sat, May 11, 2:17 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

6 lines

Diff 138040

sys/kern/kern_sysctl.c

Loading...