Page MenuHomeFreeBSD
Differential D8189

Connect new libgcc_eh and libgcc_s to the build
ClosedPublic
Actions

Authored by emaste on Oct 7 2016, 9:17 PM.
Tags
None
Referenced Files
F102710829: D8189.diff
Sat, Nov 16, 4:56 AM
Unknown Object (File)
Tue, Nov 12, 3:13 AM
Unknown Object (File)
Mon, Nov 11, 3:31 PM
Unknown Object (File)
Sun, Nov 10, 12:22 AM
Unknown Object (File)
Fri, Nov 8, 7:43 AM
Unknown Object (File)
Thu, Nov 7, 3:47 PM
Unknown Object (File)
Wed, Nov 6, 9:23 PM
Unknown Object (File)
Tue, Nov 5, 6:23 AM
View All Files
Subscribers
bapt
brooks

Details

Reviewers
brooks
dim
theraven
ed
Commits
rS308308: Connect new LLVM-based libgcc_eh & libgcc_s to the build
Summary

exp-run will be requested before commit

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 21171.Oct 7 2016, 9:17 PM
emaste retitled this revision from to Connect new libgcc_eh and libgcc_s to the build.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: theraven, dim, ed.
emaste added a parent revision: D8188: Introduce lib/libgcc_eh and lib/libgcc_s for LLVM's implementation.
emaste added a subscriber: bapt.
ed accepted this revision.Oct 13 2016, 6:35 PM
ed edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 6:35 PM
ed added inline comments.Oct 13 2016, 6:36 PM
lib/Makefile
169

The rest of this Makefile uses .if ${MK_*} != "no". Is one method preferred over the other?

emaste added inline comments.Oct 13 2016, 9:44 PM
lib/Makefile
169

I think SUBDIR.${MK_*} is preferred, but I suspect lib/Makefile was not converted because it has some more complex cases other than just ${MK_*} != "no".

I posted D8246 to convert the simple cases to SUBDIR.${MK_*}

emaste updated this revision to Diff 21391.Oct 14 2016, 3:58 PM
emaste edited edge metadata.

Rebase after rS307243

This revision now requires review to proceed.Oct 14 2016, 3:58 PM
emaste added a comment.Oct 14 2016, 4:02 PM

Exp-run requested in PR 213480

emaste added a parent revision: D8301: Don't build libssp as a prereq lib if WITHOUT_SSP is set.Oct 20 2016, 6:28 PM
emaste updated this revision to Diff 21554.Oct 20 2016, 6:31 PM
emaste edited edge metadata.
  • rebase on D8301
  • in gnu/lib/Makefile exclude gnu/lib/libgcc subdir under WITH_LLVM_LIBUNWIND
emaste added a subscriber: brooks.Oct 20 2016, 6:31 PM
brooks accepted this revision.Oct 20 2016, 8:48 PM
brooks added a reviewer: brooks.

LGTM

This revision is now accepted and ready to land.Oct 20 2016, 8:48 PM
ed accepted this revision.Oct 21 2016, 5:20 AM
ed edited edge metadata.
Closed by commit rS308308: Connect new LLVM-based libgcc_eh & libgcc_s to the build (authored by emaste). · Explain WhyNov 4 2016, 7:36 PM
This revision was automatically updated to reflect the committed changes.
dim mentioned this in rS360643: Merge additions of LLVM libunwind libgcc_eh and libgcc_s. This is in.May 4 2020, 10:59 PM

Revision Contents
Changeset List

PathSize
19 lines
gnu/
lib/
6 lines
libgcc/
37 lines
lib/
2 lines

Diff 21554

View Options

Makefile.inc1

Loading...
View Options

gnu/lib/Makefile

Loading...
View Options

gnu/lib/libgcc/Makefile

Loading...
View Options

lib/Makefile

Loading...