Page MenuHomeFreeBSD

Don't build libssp as a prereq lib if WITHOUT_SSP is set
ClosedPublic

Authored by emaste on Oct 20 2016, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 5:51 AM
Unknown Object (File)
Sat, Nov 16, 5:38 AM
Unknown Object (File)
Sat, Nov 16, 4:01 AM
Unknown Object (File)
Sun, Nov 3, 4:10 AM
Unknown Object (File)
Sun, Nov 3, 4:10 AM
Unknown Object (File)
Sun, Nov 3, 4:10 AM
Unknown Object (File)
Sun, Nov 3, 4:10 AM
Unknown Object (File)
Sat, Nov 2, 8:34 AM
Subscribers

Details

Summary

Note that this changes the ordering of _prereq_libs entries, which are built serially. I have a build running now to make sure the build is still successful, but would appreciate confirmation. (Or information that changing the order is not acceptable.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to Don't build libssp as a prereq lib if WITHOUT_SSP is set.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: bdrewery, imp.
emaste added a subscriber: brooks.
Makefile.inc1
1986 ↗(On Diff #21548)

Is removing gnu from gnu/lib/libgcc intended?

Fix gnu/lib/libgcc vs lib/libgcc reported by @brooks

brooks added a reviewer: brooks.

LGTM subject to the ordering change working

This revision is now accepted and ready to land.Oct 20 2016, 8:56 PM

LGTM subject to the ordering change working

Tinderbox is currently (still) broken by the netmap import but buildworld seems OK.

@kan originally added this in rS195697, which points out that libgcc is linked last and cannot depend on ssp symbols.

This revision was automatically updated to reflect the committed changes.