Paths

Table of Contentst

Differential D8301

Don't build libssp as a prereq lib if WITHOUT_SSP is set
ClosedPublic
Actions

Authored by emaste on Oct 20 2016, 5:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 5:51 AM

	Unknown Object (File)
	Sat, Nov 16, 5:38 AM

	Unknown Object (File)
	Sat, Nov 16, 4:01 AM

	Unknown Object (File)
	Sun, Nov 3, 4:10 AM

	Unknown Object (File)
	Sun, Nov 3, 4:10 AM

	Unknown Object (File)
	Sun, Nov 3, 4:10 AM

	Unknown Object (File)
	Sun, Nov 3, 4:10 AM

	Unknown Object (File)
	Sat, Nov 2, 8:34 AM

Subscribers

Details

Reviewers

brooks
imp
bdrewery

Commits

rS307690: Don't build libssp as a prereq lib if WITHOUT_SSP is set

Summary

Note that this changes the ordering of _prereq_libs entries, which are built serially. I have a build running now to make sure the build is still successful, but would appreciate confirmation. (Or information that changing the order is not acceptable.)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 21548.Oct 20 2016, 5:23 PM

emaste retitled this revision from to Don't build libssp as a prereq lib if WITHOUT_SSP is set.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: bdrewery, imp.

emaste added a subscriber: brooks.

brooks added inline comments.Oct 20 2016, 5:35 PM

Makefile.inc1
1986 ↗	(On Diff #21548)	Is removing `gnu` from `gnu/lib/libgcc` intended?

Fix gnu/lib/libgcc vs lib/libgcc reported by @brooks

emaste added a child revision: D8189: Connect new libgcc_eh and libgcc_s to the build.Oct 20 2016, 6:28 PM

emaste mentioned this in D8189: Connect new libgcc_eh and libgcc_s to the build.Oct 20 2016, 6:31 PM

LGTM subject to the ordering change working

This revision is now accepted and ready to land.Oct 20 2016, 8:56 PM

In D8301#172847, @brooks wrote:

LGTM subject to the ordering change working

Tinderbox is currently (still) broken by the netmap import but buildworld seems OK.

@kan originally added this in rS195697, which points out that libgcc is linked last and cannot depend on ssp symbols.

Closed by commit rS307690: Don't build libssp as a prereq lib if WITHOUT_SSP is set (authored by emaste). · Explain WhyOct 20 2016, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

5 lines

Diff 21560

head/Makefile.inc1

Loading...