Page MenuHomeFreeBSD
Differential D7160

Create a TARGET_CPUARCH thing which fixes check-old after r302391.
ClosedPublic
Actions

Authored by bdrewery on Jul 8 2016, 7:28 PM.
Tags
None
Referenced Files
F102815657: D7160.diff
Sun, Nov 17, 1:33 PM
Unknown Object (File)
Wed, Oct 23, 11:58 AM
Unknown Object (File)
Oct 18 2024, 12:12 PM
Unknown Object (File)
Oct 3 2024, 4:24 AM
Unknown Object (File)
Sep 27 2024, 10:25 AM
Unknown Object (File)
Sep 27 2024, 9:37 AM
Unknown Object (File)
Sep 27 2024, 9:23 AM
Unknown Object (File)
Sep 27 2024, 9:23 AM
View All 46 Files
Subscribers
emaste
gjb

Details

Reviewers
jhibbits
andrew
imp
• ian
Commits
rS302671: Create a TARGET_CPUARCH thing to go with MACHINE_CPUARCH.
Summary

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4460
Build 4511: arc lint + arc unit

Event Timeline

bdrewery updated this revision to Diff 18227.Jul 8 2016, 7:28 PM
bdrewery retitled this revision from to Create a TARGET_CPUARCH thing which fixes check-old after r302391..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added reviewers: imp, jhibbits, andrew, • ian.
bdrewery added a subscriber: gjb.
Herald added a subscriber: emaste. · View Herald TranscriptJul 8 2016, 7:28 PM
bdrewery added a parent revision: D7159: Create one list of replacements for MACHINE_CPUARCH as MACHINE_CPUARCH_SUB..Jul 8 2016, 7:28 PM
jhibbits accepted this revision.Jul 8 2016, 7:37 PM
jhibbits edited edge metadata.

Still confused over the difference of ${TARGET} vs ${TARGET_CPUARCH}, and for that matter, as you said on IRC, ${MACHINE} vs ${MACHINE_CPUARCH}.

Looks fine, though.

This revision is now accepted and ready to land.Jul 8 2016, 7:37 PM
bdrewery added a comment.Jul 8 2016, 7:40 PM
In D7160#148994, @jhibbits wrote:

Still confused over the difference of ${TARGET} vs ${TARGET_CPUARCH}, and for that matter, as you said on IRC, ${MACHINE} vs ${MACHINE_CPUARCH}.

Looks fine, though.

No clue, but we support all 3 for Makefiles at least via share/mk/bsd.arch.inc.mk:

.if exists(${.CURDIR}/Makefile.${MACHINE})
.include "Makefile.${MACHINE}"
.elif exists(${.CURDIR}/Makefile.${MACHINE_ARCH})
.include "Makefile.${MACHINE_ARCH}"
.elif exists(${.CURDIR}/Makefile.${MACHINE_CPUARCH})
.include "Makefile.${MACHINE_CPUARCH}"
.endif
bdrewery added a comment.Jul 8 2016, 8:16 PM

This is no longer needed to fix 'check-old' after rS302449. It may still be useful though.

Closed by commit rS302671: Create a TARGET_CPUARCH thing to go with MACHINE_CPUARCH. (authored by bdrewery). · Explain WhyJul 12 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines

Diff 18227

View Options

Makefile.inc1

Loading...