The header vm_object.h is included in vm_phys.h and uma_core.h, where it is not necessary. Remove it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Did you checked that vm/vm_object.h does not get pulled through any other header? E.g. you can add a temporal fragment like
#ifdef _VM_OBJECT_ #error "vm/vm_object.h still included" #endif
to these two .c files to be sure.
Comment Actions
I ran this command:
:src $ grep -r --include=*.[h] vm_object.h . ./sys/compat/linuxkpi/common/include/linux/list.h:#include <vm/vm_object.h> ./sys/compat/linuxkpi/common/include/linux/gfp.h:#include <vm/vm_object.h> ./sys/contrib/openzfs/include/os/freebsd/spl/sys/vnode.h:#include <vm/vm_object.h> ./sys/contrib/openzfs/include/os/freebsd/zfs/sys/zfs_znode_impl.h:#include <vm/vm_object.h> ./sys/dev/drm2/drmP.h:#include <vm/vm_object.h> ./sys/fs/nfs/nfsport.h:#include <vm/vm_object.h>
and concluded that neither of these files was including a file that included vm_object.h.