Page MenuHomeFreeBSD
Differential D50034

efivar: Test uuid against zero
Needs ReviewPublic
Actions

Authored by imp on Fri, Apr 25, 7:33 PM.
Tags
None
Referenced Files
F115677108: D50034.id.diff
Sun, Apr 27, 12:02 AM
F115670158: D50034.id154304.diff
Sat, Apr 26, 9:24 PM
F115648784: D50034.diff
Sat, Apr 26, 1:15 PM
Subscribers
None

Details

Reviewers
tsoome
kevans
kib
Summary

Test the passed in GuID against a guid of all 0's. This removes another
place that has to worry about the difference between uuit_t and
EFI_GUID.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63739
Build 60623: arc lint + arc unit

Event Timeline

imp requested review of this revision.Fri, Apr 25, 7:33 PM
imp created this revision.
Harbormaster completed remote builds in B63739: Diff 154304.Fri, Apr 25, 7:33 PM
imp added a parent revision: D50033: efivar: Use memcmp instead of uuid_ functions to compare.Fri, Apr 25, 7:33 PM
imp added a child revision: D50035: efivar: Allow uuid_t and efi_guid_t to be different types..
kevans added inline comments.Fri, Apr 25, 7:36 PM
lib/libefivar/efivar.c
297

Consider dropping zero in favor of efi_guid_empty

Revision Contents
Changeset List

PathSize
lib/
libefivar/
5 lines

Diff 154304

View Options

lib/libefivar/efivar.c

Loading...