Page MenuHomeFreeBSD

vm_pageout: rewrite cluster()
ClosedPublic

Authored by dougm on Tue, Apr 15, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 23, 7:35 PM
Unknown Object (File)
Sat, Apr 19, 7:43 PM
Unknown Object (File)
Sat, Apr 19, 5:51 PM
Unknown Object (File)
Sat, Apr 19, 2:46 PM
Unknown Object (File)
Sat, Apr 19, 2:14 PM
Unknown Object (File)
Sat, Apr 19, 2:11 PM
Unknown Object (File)
Sat, Apr 19, 2:10 PM
Unknown Object (File)
Sat, Apr 19, 2:03 PM
Subscribers

Details

Summary

Implement vm_pageout_cluster using iterators instead of vm_page_next() and vm_page_prev().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Tue, Apr 15, 6:47 PM
dougm created this revision.
sys/vm/vm_pageout.c
396

Could we please avoid jumping into the loop body from outside? Wouldn't the code work same if the 'more' label is left at the old position, before the reverse scan while() loop, by checking the true condition?

dougm marked an inline comment as done.

Modify vm_pageout_cluster() to avoid labels and gotos.

This revision is now accepted and ready to land.Thu, Apr 17, 1:50 PM
This revision was automatically updated to reflect the committed changes.