Page MenuHomeFreeBSD
Differential D49651

stat(2): add st_bsdflags field
ClosedPublic
Actions

Authored by kib on Wed, Apr 2, 8:45 PM.
Tags
None
Referenced Files
F113801941: D49651.id153058.diff
Thu, Apr 3, 8:16 PM
F113797053: D49651.id.diff
Thu, Apr 3, 6:40 PM
F113790022: D49651.id153058.diff
Thu, Apr 3, 4:11 PM
F113788698: D49651.id.diff
Thu, Apr 3, 3:40 PM
F113787736: D49651.diff
Thu, Apr 3, 3:16 PM
F113787587: D49651.diff
Thu, Apr 3, 3:12 PM
F113770050: D49651.diff
Thu, Apr 3, 8:50 AM
Subscribers
imp
olce

Details

Reviewers
rmacklem
markj
asomers
Commits
rG86db734ae292: stat(2): add st_bsdflags field

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Wed, Apr 2, 8:45 PM
Herald added subscribers: olce, imp. · View Herald TranscriptWed, Apr 2, 8:45 PM
kib requested review of this revision.Wed, Apr 2, 8:45 PM
rmacklem accepted this revision.Wed, Apr 2, 8:57 PM

All looks good to me. (I am glad you did this. I would have missed
half of the places that needed to be changed.)

I think what I defined as VA_NAMEDATTR_TYPE needs to be replaced
with SFB_NAMEDATTR?

This revision is now accepted and ready to land.Wed, Apr 2, 8:57 PM
kib added a comment.Wed, Apr 2, 9:03 PM
In D49651#1131856, @rmacklem wrote:

All looks good to me. (I am glad you did this. I would have missed
half of the places that needed to be changed.)

I think what I defined as VA_NAMEDATTR_TYPE needs to be replaced
with SFB_NAMEDATTR?

Yes, I wrote the patch with the assumption that va_bsdflags are filled directly by filesystem. So VA_NAMEDATTR_TYPE seems to be not needed.

markj added inline comments.Wed, Apr 2, 9:09 PM
sys/sys/stat.h
344

I'd use SFBSD_ as a prefix.

sys/ufs/ufs/ufs_vnops.c
565 ↗(On Diff #153055)

This isn't needed I think, vop_stat_helper_pre() clears the new field.

rmacklem mentioned this in rG6441407b297e: vnode.h: Delete VA_NAMEDATTR_TYPE.Wed, Apr 2, 9:18 PM
kib updated this revision to Diff 153058.Wed, Apr 2, 9:34 PM
kib marked 2 inline comments as done.

SFBSD_

This revision now requires review to proceed.Wed, Apr 2, 9:34 PM
markj accepted this revision.Thu, Apr 3, 1:18 PM
markj added inline comments.
sys/fs/tmpfs/tmpfs_vnops.c
480 ↗(On Diff #153058)

This is unneeded too.

This revision is now accepted and ready to land.Thu, Apr 3, 1:18 PM
kib marked an inline comment as done.Thu, Apr 3, 2:45 PM
Closed by commit rG86db734ae292: stat(2): add st_bsdflags field (authored by kib). · Explain WhyThu, Apr 3, 3:01 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG86db734ae292: stat(2): add st_bsdflags field.

Revision Contents
Changeset List

PathSize
sys/
compat/
freebsd32/
2 lines
2 lines
kern/
1 line
2 lines
1 line
sys/
5 lines
4 lines

Diff 153078

View Options

sys/compat/freebsd32/freebsd32.h

Loading...
View Options

sys/compat/freebsd32/freebsd32_misc.c

Loading...
View Options

sys/kern/kern_descrip.c

Loading...
View Options

sys/kern/vfs_default.c

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/sys/stat.h

Loading...
View Options

sys/sys/vnode.h

Loading...