Differential D49642

ctld: Reduce code duplication in auth_check_secret_length
ClosedPublic
Actions

Authored by jhb on Wed, Apr 2, 8:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 21, 2:47 PM

	Unknown Object (File)
	Tue, Apr 15, 1:02 AM

	Unknown Object (File)
	Sun, Apr 13, 6:34 AM

	Unknown Object (File)
	Fri, Apr 11, 3:25 PM

	Unknown Object (File)
	Fri, Apr 11, 3:25 PM

	Unknown Object (File)
	Sat, Apr 5, 11:36 AM

	Unknown Object (File)
	Fri, Apr 4, 12:57 PM

	Unknown Object (File)
	Fri, Apr 4, 12:54 PM

Subscribers

Details

Reviewers

Commits

rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length

Summary

Only check a single secret length in the function and call it twice
for the CHAP-MUTUAL case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63287
Build 60171: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Apr 2, 8:04 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Apr 2, 8:04 PM

jhb requested review of this revision.Wed, Apr 2, 8:04 PM

Harbormaster completed remote builds in B63287: Diff 153041.Wed, Apr 2, 8:04 PM

jhb added a parent revision: D49641: ctld: Fix sign bug validating kernel ports when reloading config.Wed, Apr 2, 8:04 PM

jhb added a child revision: D49643: ctld: Add a label string to auth_groups.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Apr 11, 2:04 PM

Closed by commit rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4214775235eb: ctld: Reduce code duplication in auth_check_secret_length.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

67 lines

Diff 153041

usr.sbin/ctld/ctld.cc

Loading...