Page MenuHomeFreeBSD
Differential D49608

queue: Add STAILQ_SPLIT_AFTER() and STAILQ_ASSERT_NONEMPTY()
Needs ReviewPublic
Actions

Authored by olce on Tue, Apr 1, 1:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 5:17 PM
Unknown Object (File)
Thu, Apr 3, 11:43 AM
Unknown Object (File)
Thu, Apr 3, 6:01 AM
Subscribers
imp

Details

Reviewers
emaste
markj
Summary

STAILQ_SPLIT_AFTER() allows to split an existing queue in two. It is
the missing block that enables arbitrary splitting and recombinations of
queues, together with STAILQ_CONCAT() and STAILQ_SWAP().

Add STAILQ_ASSERT_NONEMPTY(), used by STAILQ_SPLIT_AFTER().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63250
Build 60134: arc lint + arc unit

Event Timeline

olce created this revision.Tue, Apr 1, 1:37 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 1, 1:37 PM
olce requested review of this revision.Tue, Apr 1, 1:37 PM
Harbormaster completed remote builds in B63250: Diff 152968.Tue, Apr 1, 1:37 PM
olce added a parent revision: D49607: ps(1): Have parsefmt() take the list of columns to update.Tue, Apr 1, 1:39 PM
olce added a child revision: D49609: ps(1): find_varentry() to take a name instead of a VAR.
olce added a reviewer: markj.Tue, Apr 1, 4:29 PM
markj added a comment.Wed, Apr 2, 12:08 PM

The implementation looks fine to me. queue.3 needs an update as well.

sys/sys/queue.h
483

Does it make sense to add QMD_STAILQ_CHECK_TAIL(head) as well?

olce updated this revision to Diff 153146.Fri, Apr 4, 10:43 AM
olce edited the summary of this revision. (Show Details)
  • STAILQ_SPLIT_AFTER(): Add a call to QMD_STAILQ_CHECK_TAIL().
  • STAILQ_SPLIT_AFTER(): Simplify the test determining if elm is the last element of the stailq.
  • Expand a bit the commit message.
Harbormaster completed remote builds in B63320: Diff 153146.Fri, Apr 4, 10:43 AM
olce marked an inline comment as done.Fri, Apr 4, 10:43 AM
olce edited the summary of this revision. (Show Details)Fri, Apr 4, 10:45 AM
olce added a comment.Fri, Apr 4, 11:55 AM
In D49608#1131466, @markj wrote:

The implementation looks fine to me. queue.3 needs an update as well.

Will do that in a later commit. In between, going to submit more changes to queue.h, including the implementation of _SPLIT_AFTER for all lists/tailqs variants.

Revision Contents
Changeset List

PathSize
sys/
sys/
34 lines

Diff 152968

View Options

sys/sys/queue.h

Loading...