Page MenuHomeFreeBSD
Differential D49618

ps.1: '-A' and '-a': Note change in behavior
Needs ReviewPublic
Actions

Authored by olce on Tue, Apr 1, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 2:47 AM
Unknown Object (File)
Mon, Apr 14, 10:39 PM
Unknown Object (File)
Mon, Apr 14, 2:20 PM
Unknown Object (File)
Mon, Apr 14, 1:26 PM
Unknown Object (File)
Sun, Apr 13, 2:14 AM
Unknown Object (File)
Thu, Apr 10, 9:13 PM
Unknown Object (File)
Sat, Apr 5, 12:08 PM
Unknown Object (File)
Fri, Apr 4, 8:48 PM
View All 12 Files
Subscribers
imp
jonathan
ziaee

Details

Reviewers
emaste
ziaee
Group Reviewers
manpages

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63315
Build 60199: arc lint + arc unit

Event Timeline

olce created this revision.Tue, Apr 1, 1:38 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Apr 1, 1:38 PM
olce requested review of this revision.Tue, Apr 1, 1:38 PM
Harbormaster completed remote builds in B63260: Diff 152978.Tue, Apr 1, 1:38 PM
olce added a parent revision: D49617: ps(1): Make '-a' and '-A' always show all processes.Tue, Apr 1, 1:40 PM
olce added a child revision: D49619: ps(1): Match current user's processes using ps' effective UID.
olce added a reviewer: ziaee.Tue, Apr 1, 1:44 PM
olce added a reviewer: manpages.Tue, Apr 1, 1:48 PM
emaste added a comment.Wed, Apr 2, 2:14 PM

The doc change should be included in the same commit that changes the behaviour

olce updated this revision to Diff 153090.Thu, Apr 3, 7:18 PM
  • Update base (impacts of changes earlier in the series).
Herald added a subscriber: jonathan. · View Herald TranscriptThu, Apr 3, 7:18 PM
Harbormaster completed remote builds in B63311: Diff 153090.Thu, Apr 3, 7:18 PM
imp added a comment.Thu, Apr 3, 7:31 PM

These changes are way way more than the note about a vs A.... they appear to cover other things and also sort and maybe other stuff. Eachbof the logical changes should be separate

olce added a comment.Thu, Apr 3, 7:33 PM
In D49618#1132119, @imp wrote:

These changes are way way more than the note about a vs A.... they appear to cover other things and also sort and maybe other stuff. Eachbof the logical changes should be separate

Ah, I just updated a wrong diff...

olce updated this revision to Diff 153097.Thu, Apr 3, 7:33 PM

Update with the right diff

Harbormaster completed remote builds in B63315: Diff 153097.Thu, Apr 3, 7:34 PM
olce added a comment.Thu, Apr 3, 7:35 PM

@imp The erroneous diff was that of D49605. Thanks for the heads up.

olce added a comment.Thu, Apr 3, 7:35 PM
In D49618#1131522, @emaste wrote:

The doc change should be included in the same commit that changes the behaviour

Yes, will do that on commit.

Revision Contents
Changeset List

PathSize
bin/
ps/
25 lines

Diff 153097

View Options

bin/ps/ps.1

Loading...