Page MenuHomeFreeBSD

wifi-firmware-{iwlwifi,*}-kmod: add missing firmware files
AcceptedPublic

Authored by bz on Tue, Mar 18, 3:08 PM.

Details

Reviewers
thj
jrm
Group Reviewers
Ports Committers
Summary

The firmware files for iwlwifi were lacking entries for some older
versions on 14.2-RELEASE and stable/14 [1] before src:f4e352ef16d6.

In addition iwx(4) switched to using the same firmware file names
as iwlwifi so that fwget(8) would work for both of them (D49259).
We add the set of iwx(4) firmware files hard coded to the list of
files.

Given the list of supported revisions will grow and maintaining them
for all branches will be tedious without overlap we will simply create
the lists and let make do the job of :O:u (sort/uniq) in the common
Makefile.inc to filter out duplicates between branches.

Installing newer firmware also on stable branches will allow forward
updates. For iwlwifi(4) it is less of a problem given it will use an
older version of firmware still (and we are not hoping to fall out
of the min/max window) but other drivers may not have such a
versioned scheme and we cannot easily run fwget(8) for a newer
release with the old kernel (and once we have an updated kernel/driver
the old firmware is not guaranteed to work anymore).

It would be helpful if we could forget about firmware once a release
is out (given kmod packages are built) but anyone else building the
packages themselves would still use a newer ports tree so we will have
to at least support older versions until the EoL date of the last
release using them.

Admittedly it was easier having the firmware files bundled with src
as most of these problems were solved naturally.

For iwlwifi flavors 22000, ax201, and bz also add a tunable to
automatically turn on hw_crypto, HT and VHT support given we
believe it works for these chipsets.

Sponsored by: The FreeBSD Foundation
Reported by: Stephane D'Alu (sdalu sdalu.com) [1]
PR: 284475 [1]

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 62960
Build 59844: arc lint + arc unit

Event Timeline

bz requested review of this revision.Tue, Mar 18, 3:08 PM
bz created this revision.

On my slightly older current: [current-D49403_iwlwifi_fw_update] [2025-03-18_16h39m38s] [committing] Queued: 34 Built: 34 Failed: 0 Skipped: 0 Ignored: 0 Fetched: 0 Tobuild: 0 Time: 00:03:25

bz added a reviewer: Ports Committers.
jrm added inline comments.
net/wifi-firmware-iwlwifi-kmod/Makefile
35–70

I'm unclear why these were changed to +=. Won't these always be empty before here?

net/wifi-firmware-mt7601u-kmod/Makefile
2

PORTREVISON remains 2, so this is ok.

This revision is now accepted and ready to land.Tue, Mar 18, 9:38 PM
bz marked 2 inline comments as done.Tue, Mar 18, 10:03 PM

Thanks a lot Joe!

net/wifi-firmware-iwlwifi-kmod/Makefile
35–70

Mostly just because so that in the future I don't have to be careful about order of the various branches or additions. Might make more sense to append the dynamic bits with the next update rather than leaving main at the top. Dunno.

net/wifi-firmware-mt7601u-kmod/Makefile
2

Yes forgot to mention in the commit message that I just bumped all to 2 but for mt7601u there's no changes so they can all stay on the same number.