Paths

Table of Contentst

Differential D49399

Add driver for the RK3328 GPIO_MUTE pin
ClosedPublic
Actions

Authored by shurd on Mon, Mar 17, 9:50 PM.

Tags

None

Referenced Files

	F113695747: D49399.diff
	Wed, Apr 2, 4:07 AM

	Unknown Object (File)
	Thu, Mar 20, 9:57 PM

Subscribers

Details

Reviewers

andrew
manu
linimon

Commits

rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin

Summary

This is used in in the ROC-RK3328-CC to control a regulator.

Test Plan

Tested on ROC-RK3328-CC board

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 62949
Build 59833: arc lint + arc unit

Event Timeline

shurd created this revision.Mon, Mar 17, 9:50 PM

Herald added a reviewer: andrew. · View Herald TranscriptMon, Mar 17, 9:50 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: ziaee, emaste, imp. · View Herald Transcript

shurd requested review of this revision.Mon, Mar 17, 9:50 PM

Harbormaster completed remote builds in B62947: Diff 152365.Mon, Mar 17, 9:50 PM

shurd added a reviewer: linimon.Mon, Mar 17, 9:54 PM

Fix copyright

Harbormaster completed remote builds in B62948: Diff 152367.Mon, Mar 17, 9:57 PM

Fix copyright and update wrapping

Harbormaster completed remote builds in B62949: Diff 152368.Mon, Mar 17, 10:04 PM

I don't know what this does, but thank you for writing a manual with it! Some minor style suggestions and questions:

share/man/man4/man4.aarch64/rk_grf_gpio.4
2	The project this `-` was added for was abandoned
3	You could use SPDX only now if you want, there's an example in style(9)
31	This is more than one line. How's this? The rendered line barely fits on standard console.
37	Does it support the gpio or only the gpio_mute pin? How can people use it? What does it do? That would be really nice in this section.
40–43
52	I see no reason why we couldn't, but we don't usually say "device driver" lately.
57

Address manual feedback

Harbormaster completed remote builds in B62950: Diff 152371.Tue, Mar 18, 12:25 AM

shurd marked 7 inline comments as done.Tue, Mar 18, 12:27 AM

shurd added inline comments.

share/man/man4/man4.aarch64/rk_grf_gpio.4
31	Should be better now (certainly shorter)

was->were

Harbormaster completed remote builds in B62951: Diff 152372.Tue, Mar 18, 12:29 AM

Another typo, CPIO -> GPIO

Harbormaster completed remote builds in B62953: Diff 152374.Tue, Mar 18, 12:38 AM

Update .c file per style(9) as well.

Harbormaster completed remote builds in B62954: Diff 152375.Tue, Mar 18, 1:08 AM

Remove unneeded headers

Harbormaster completed remote builds in B62955: Diff 152376.Tue, Mar 18, 1:15 AM

manu accepted this revision.Tue, Mar 18, 7:34 AM

This revision is now accepted and ready to land.Tue, Mar 18, 7:34 AM

Closed by commit rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin (authored by shurd). · Explain WhyTue, Mar 18, 5:01 PM

This revision was automatically updated to reflect the committed changes.

shurd added a commit: rG0832a409c21b: Add driver for the RK3328 GPIO_MUTE pin.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

man4.aarch64/

1 line

58 lines

sys/

arm/

rockchip/

1 line

arm64/

rockchip/

261 lines

conf/

1 line

Diff 152368

share/man/man4/man4.aarch64/Makefile

Loading...

share/man/man4/man4.aarch64/rk_grf_gpio.4

Loading...

sys/arm/rockchip/files.rk32xx

Loading...

sys/arm64/rockchip/rk_grf_gpio.c

Loading...

sys/conf/files.arm64

Loading...