Page MenuHomeFreeBSD

sys: add wlan_gcmp to GENERIC kernels as appropriate
AcceptedPublic

Authored by adrian on Thu, Mar 13, 3:11 PM.
Referenced Files
F112543732: D49343.diff
Wed, Mar 19, 3:25 PM
Unknown Object (File)
Sat, Mar 15, 11:42 PM
Unknown Object (File)
Sat, Mar 15, 7:09 PM
Unknown Object (File)
Sat, Mar 15, 12:05 PM
Unknown Object (File)
Fri, Mar 14, 6:57 PM
Unknown Object (File)
Fri, Mar 14, 4:05 PM
Unknown Object (File)
Fri, Mar 14, 12:56 PM
Subscribers

Details

Reviewers
andrew
cy
bz
Group Reviewers
wireless
Summary

Add wlan_gcmp wherever CCMP is defined in kernel configs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62902
Build 59786: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Thu, Mar 13, 11:37 PM

Tested this w/ hostapd configs enabling GCMP, seems to work!

Unrelated thought:

  • Do any of these kernel files differ for wifi? Otherwise we should contemplate adding a std.wlan to sys/conf/ maybe and include that for all. Would also then be a lot easier to fix arm64 ;-)

Yeah, creating a std.wifi would be good, especially for the options versus the stack and drivers.

I'll pencil that in for a refactor after all of this lands.

Thanks for the suggestion/idea! Honestly it's been bugging me for years too.

Yeah, creating a std.wifi would be good, especially for the options versus the stack and drivers.

I'll pencil that in for a refactor after all of this lands.

Thanks for the suggestion/idea! Honestly it's been bugging me for years too.

Having looked at sys/modules/Makefile I probably wouldn't do the drivers but all the options/devices.

In general as soon as a driver supports PNP and isn't needed to get to init we probably shouldn't include them in GENERIC anymore but that's a different story and I keep forgetting how this is supposed to be handled today vs. MINIMAL and other kernel configs.

Wifi is kinda a special case. We have multiple drivers for the same hardware that play badly together because linuxkpi driver bidding model sucks.

I do like std.wifi for the stack. Not for the drivers which are their own problem.