Differential D48933

ctld: Fix parsing of text values for DSCP in UCL parser
ClosedPublic
Actions

Authored by jhb on Tue, Feb 11, 1:20 AM.

Tags

None

Referenced Files

	F110607718: D48933.diff
	Thu, Feb 20, 8:13 PM

	Unknown Object (File)
	Sun, Feb 16, 1:20 PM

	Unknown Object (File)
	Wed, Feb 12, 9:10 PM

Subscribers

Details

Reviewers

Commits

rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Tue, Feb 11, 1:20 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 11, 1:20 AM

Harbormaster completed remote builds in B62360: Diff 150822.Tue, Feb 11, 1:20 AM

jhb requested review of this revision.Tue, Feb 11, 1:20 AM

jhb added a parent revision: D48932: ctld: Use preferred style for evaluating result of strcmp.

jhb added a child revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.

The old code certainly looks broken. I guess nobody was using it?

This revision is now accepted and ready to land.Tue, Feb 11, 6:35 PM

In D48933#1116308, @asomers wrote:

The old code certainly looks broken. I guess nobody was using it?

Yes, my guess is that the UCL paths weren't well tested.

Closed by commit rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser (authored by jhb). · Explain WhyWed, Feb 12, 7:35 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5e6a462277b1: ctld: Fix parsing of text values for DSCP in UCL parser.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

44 lines

Diff 150925

usr.sbin/ctld/uclparse.c

Loading...