While we're here, send the etcupdate log from generating base.txz
to stdout instead of /dev/null (see e972e408d19a) as well.
MFC after: 1 week
Sponsored by: Amazon
Differential D48719
vmimage.subr: Redirect etcupdate log to stdout cperciva on Wed, Jan 29, 7:40 PM. Authored by
Details While we're here, send the etcupdate log from generating base.txz MFC after: 1 week
Diff Detail
Event TimelineComment Actions Makes sense, but as @jrtc27 suggested on IRC what about -L /dev/stdout so that the -L output ends up in the build log? Comment Actions I'm fine with doing that if @gordon agrees to make the same change in release/Makefile. I figured the two places should be the same, one way or another. Comment Actions As long as it doesn't end up as a build product, makes sense to me. Want to update the review with a new patch and we'll go from there? Comment Actions Yep, agree they should be the same. I'm fine with doing this with whatever sequence of commits folks like. Both could be switched after this commit goes in. Comment Actions Probably best to land this, since it's actually important for reproducibility, then we can update both to something else later that gives extra visibility into the build less urgently Comment Actions I figure it's easier to do this in one commit rather than making a change and then changing it again. Looks ok to everyone? |