Page MenuHomeFreeBSD

vmimage.subr: Redirect etcupdate log to stdout
AcceptedPublic

Authored by cperciva on Wed, Jan 29, 7:40 PM.

Details

Summary

While we're here, send the etcupdate log from generating base.txz
to stdout instead of /dev/null (see e972e408d19a) as well.

MFC after: 1 week
Sponsored by: Amazon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62149
Build 59033: arc lint + arc unit

Event Timeline

emaste added a subscriber: emaste.

Makes sense, but as @jrtc27 suggested on IRC what about -L /dev/stdout so that the -L output ends up in the build log?

This revision is now accepted and ready to land.Wed, Jan 29, 8:18 PM

Makes sense, but as @jrtc27 suggested on IRC what about -L /dev/stdout so that the -L output ends up in the build log?

I'm fine with doing that if @gordon agrees to make the same change in release/Makefile. I figured the two places should be the same, one way or another.

As long as it doesn't end up as a build product, makes sense to me. Want to update the review with a new patch and we'll go from there?

I'm fine with doing that if @gordon agrees to make the same change in release/Makefile. I figured the two places should be the same, one way or another.

Yep, agree they should be the same. I'm fine with doing this with whatever sequence of commits folks like. Both could be switched after this commit goes in.

Probably best to land this, since it's actually important for reproducibility, then we can update both to something else later that gives extra visibility into the build less urgently

This revision now requires review to proceed.Thu, Jan 30, 5:18 PM
cperciva retitled this revision from vmimage.subr: Redirect etcupdate log to /dev/null to vmimage.subr: Redirect etcupdate log to stdout.Thu, Jan 30, 5:19 PM
cperciva edited the summary of this revision. (Show Details)

I figure it's easier to do this in one commit rather than making a change and then changing it again. Looks ok to everyone?

This revision is now accepted and ready to land.Thu, Jan 30, 5:22 PM