Page MenuHomeFreeBSD
Differential D48676

devinfo: Distinguish resources owned by unnamed devices from free resources
ClosedPublic
Actions

Authored by jhb on Sat, Jan 25, 3:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 10:54 PM
Unknown Object (File)
Sat, Feb 1, 12:29 AM
Unknown Object (File)
Fri, Jan 31, 5:37 PM
Unknown Object (File)
Wed, Jan 29, 10:05 PM
Unknown Object (File)
Wed, Jan 29, 6:41 PM
Unknown Object (File)
Wed, Jan 29, 4:04 PM
Unknown Object (File)
Wed, Jan 29, 3:06 PM
Unknown Object (File)
Wed, Jan 29, 10:51 AM
View All 12 Files
Subscribers
None

Details

Reviewers
imp
jrtc27
Commits
rGb8529e7c5e5b: devinfo: Distinguish resources owned by unnamed devices from free resources
Summary

For resources owned by an unnamed device, list the device name as
"(unknown)" instead of using "----". In addition, if the -v flag is
given, output the pnpinfo and location info for the device if present.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62019
Build 58903: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sat, Jan 25, 3:52 AM
jhb created this revision.
Harbormaster completed remote builds in B62019: Diff 149949.Sat, Jan 25, 3:52 AM
jhb added a parent revision: D48675: libdevinfo: Avoid false positives for the root0 sentinel value.Sat, Jan 25, 3:52 AM
jhb added a comment.Sat, Jan 25, 3:55 AM

Compared to the output from the previous review, the changed lines for devinfo -uv are:

I/O ports:
...
    0x20-0x21 (unknown) pnpinfo _HID=PNP0000 _UID=0 _CID=none at handle=\_SB_.PC00.ISA_.PIC_
...
    0xa0-0xa1 (unknown) pnpinfo _HID=PNP0000 _UID=0 _CID=none at handle=\_SB_.PC00.ISA_.PIC_

Without -v you just get (unknown). This seems useful to me though when looking at these ranges.

These are reserved resources, btw, that probably wasn't a thing that existed when devinfo(8) was written.

imp accepted this revision.Sun, Jan 26, 12:57 AM

Yea, our ACPI impl has always been a bit weird when it comes to reserved ranges of things... The more insight we have into these devices, the better.

This revision is now accepted and ready to land.Sun, Jan 26, 12:57 AM
Closed by commit rGb8529e7c5e5b: devinfo: Distinguish resources owned by unnamed devices from free resources (authored by jhb). · Explain WhyWed, Jan 29, 3:05 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGb8529e7c5e5b: devinfo: Distinguish resources owned by unnamed devices from free resources.

Revision Contents
Changeset List

PathSize
usr.sbin/
devinfo/
2 lines
14 lines

Diff 149949

View Options

usr.sbin/devinfo/devinfo.8

Loading...
View Options

usr.sbin/devinfo/devinfo.c

Loading...