vm_phys_avail_count(): Fix out-of-bounds accesses
ClosedPublic
Actions

Authored by olce on Jan 23 2025, 5:15 PM.

Details

Reviewers

markj
dougm
alc

Commits

rG7658c4f8c727: vm_phys_avail_count(): Fix out-of-bounds accesses
rG291b7bf071e8: vm_phys_avail_count(): Fix out-of-bounds accesses

Summary

On improper termination of phys_avail[] (two consecutive 0 starting at
an even index), this function would (unnecessarily) continue searching
for the termination markers even if the index was out of bounds.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62296
Build 59180: arc lint + arc unit

Event Timeline

olce created this revision.Jan 23 2025, 5:15 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2025, 5:15 PM

olce requested review of this revision.Jan 23 2025, 5:15 PM

Harbormaster completed remote builds in B61928: Diff 149785.Jan 23 2025, 5:15 PM

olce added a parent revision: D48628: vm_phys: Check for overlap when adding a segment.Jan 23 2025, 5:21 PM

olce added a child revision: D48630: vm_phys_avail_split(): Tolerate split requests at boundaries.

markj added inline comments.Jan 24 2025, 2:47 PM

sys/vm/vm_phys.c
1786

Fix spacing.

Harbormaster completed remote builds in B62296: Diff 150690.Feb 7 2025, 5:20 PM

Spacing fixed.

markj accepted this revision.Feb 18 2025, 8:05 PM

This revision is now accepted and ready to land.Feb 18 2025, 8:05 PM

Closed by commit rG291b7bf071e8: vm_phys_avail_count(): Fix out-of-bounds accesses (authored by olce). · Explain WhyFeb 19 2025, 2:14 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG291b7bf071e8: vm_phys_avail_count(): Fix out-of-bounds accesses.

olce added a commit: rG7658c4f8c727: vm_phys_avail_count(): Fix out-of-bounds accesses.Tue, Apr 8, 1:41 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_phys.c

10 lines

Diff 150690

View Options

vm_phys_avail_count(): Fix out-of-bounds accessesClosedPublicActions