vm_phys: Check for overlap when adding a segment

[olce]

Summary

Segments are passed by machine-dependent routines, so explicit checks
will make debugging much easier on very weird machines or when someone
is tweaking these machine-dependent routines. Additionally, this
operation is not performance-sensitive.

For the same reasons, test that we don't reach the maximum number of
physical segments (the compile-time of the internal storage) in
production kernel (replaces the existing KASSERT()).

While here, convert the remaining KASSERT() to MPASS2().

[markj]

sys/vm/vm_phys.c

424

Why is this an assertion when the other check applies to non-INVARIANTS kernels?

439

Stray semicolon at the end of the message?