vm_phys_avail_check(): Check index parity, fix panic messages
AcceptedPublic
Actions

Authored by olce on Thu, Jan 23, 5:15 PM.

Details

Reviewers

markj
dougm
alc

Summary

The passed index must be the start of a chunk in phys_avail[], so must
be even. Test for that and print a separate panic message.

While here, fix panic messages: In one, the wrong chunk boundary was
printed, and in another, the desired but not the actual condition was
printed, possibly leading to confusion.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61925
Build 58809: arc lint + arc unit

Event Timeline

olce created this revision.Thu, Jan 23, 5:15 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jan 23, 5:15 PM

olce requested review of this revision.Thu, Jan 23, 5:15 PM

Harbormaster completed remote builds in B61925: Diff 149782.Thu, Jan 23, 5:15 PM

olce added a child revision: D48627: vm_phys_add_seg(): Check for bad segments, allow empty ones.Thu, Jan 23, 5:21 PM

markj accepted this revision.Fri, Jan 24, 2:39 PM

This revision is now accepted and ready to land.Fri, Jan 24, 2:39 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_phys.c

10 lines

Diff 149782

View Options

vm_phys_avail_check(): Check index parity, fix panic messagesAcceptedPublicActions