bnxt_en: Retrieve maximum of 128 APP TLVs
ClosedPublic
Actions

Authored by zlei on Jan 22 2025, 12:09 PM.

Details

Reviewers

chandrakanth.patil_broadcom.com
sumit.saxena_broadcom.com
shurd
imp
markj

Commits

rGacc2d4712391: bnxt_en: Retrieve maximum of 128 APP TLVs
rG3de231b4d956: bnxt_en: Retrieve maximum of 128 APP TLVs

Summary

It appears the maximum number of APP TLVs supported by the hardware is 128 according to D45005. Well user reports that the number may exceed the limit, causing out of bound write to on-stack allocated variable app[128] and the kernel panics.

Limit to 128 while retrieving APP TLVs.

PR: 284073
Fixes: 35b53f8c989f bnxt_en: Add PFC, ETS & App TLVs protocols support
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei requested review of this revision.Jan 22 2025, 12:09 PM

zlei created this revision.

zlei edited the summary of this revision. (Show Details)Jan 22 2025, 12:20 PM

It would really be better to pass the maximum number of entries as a parameter, instead of hard-coding 128 in several places.

This revision is now accepted and ready to land.Jan 23 2025, 2:20 PM

In D48589#1108835, @markj wrote:

It would really be better to pass the maximum number of entries as a parameter, instead of hard-coding 128 in several places.

Good point.

Passed in the limit via parameter nitems .

This revision now requires review to proceed.Feb 13 2025, 4:14 PM

markj accepted this revision.Feb 13 2025, 4:52 PM

This revision is now accepted and ready to land.Feb 13 2025, 4:52 PM

Closed by commit rG3de231b4d956: bnxt_en: Retrieve maximum of 128 APP TLVs (authored by zlei). · Explain WhyFeb 14 2025, 10:42 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG3de231b4d956: bnxt_en: Retrieve maximum of 128 APP TLVs.

zlei added a commit: rGacc2d4712391: bnxt_en: Retrieve maximum of 128 APP TLVs.Sat, Feb 22, 2:52 AM