Page MenuHomeFreeBSD

bnxt_en: Add PFC, ETS & App TLVs protocols support
ClosedPublic

Authored by chandrakanth.patil_broadcom.com on Apr 29 2024, 12:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:18 AM
Unknown Object (File)
Sun, Nov 10, 5:17 AM
Unknown Object (File)
Wed, Nov 6, 7:18 PM
Unknown Object (File)
Wed, Oct 30, 3:40 PM
Unknown Object (File)
Wed, Oct 23, 1:41 PM
Unknown Object (File)
Sun, Oct 20, 6:15 AM
Unknown Object (File)
Oct 17 2024, 1:37 AM
Unknown Object (File)
Oct 17 2024, 1:37 AM
Subscribers
None

Details

Summary

Created new directory "bnxt_en" in /dev/bnxt and /modules/bnxt
and moved source files and Makefile into respective directory.

ETS support:

  • Added new files bnxt_dcb.c & bnxt_dcb.h
  • Added sysctl node 'dcb' and created handlers 'ets' and 'dcbx_cap'
  • Add logic to validate user input and configure ETS in the firmware
  • Updated makefile to include bnxt_dcb.c & bnxt_dcb.h

PFC support:

  • Created sysctl handlers 'pfc' under node 'dcb'
  • Added logic to validate user input and configure PFC in the firmware.

App TLV support:

  • Created 3 new sysctl handlers under node 'dcb'
    • set_apptlv (write only): Sets a specified TLV
    • del_apptlv (write only): Deletes a specified TLV
    • list_apptlv (read only): Lists all APP TLVs configured
  • Added logic to validate user input and configure APP TLVs in the firmware.

Added Below DCB ops for management interface:

  • Set PFC, Get PFC, Set ETS, Get ETS, Add App_TLV, Del App_TLV Lst App_TLV

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The build stuff looks good.
I can't speak to the hardware.
The extraneous (white space) changes are relatively low for vendor updates and don't get too much .

In D45005#1028822, @imp wrote:

The build stuff looks good.

Thank you. I am glad that the build changes are acceptable.

I can't speak to the hardware.

Thanks for the input! Regarding the hardware, I've tested the patch on relevant hardware and haven't encountered any issues. While I don't currently have documentation detailing the testing process, I can assure you that thorough testing has been conducted. If there's any specific information you need or if further testing is required on certain hardware configurations, please let me know, and I'll be happy to provide it

The extraneous (white space) changes are relatively low for vendor updates and don't get too much .

Thanks for your input! We'll address the whitespace in a separate cleanup patch after this patchset accepted.

This revision is now accepted and ready to land.May 27 2024, 11:27 AM