usr.bin/genl/genl.c
295	Minor style nit. Doing a declaration inside a for() loop isn't what man style recommends. If you jut cribbed this from the old code, then it's ok.

This revision is now accepted and ready to land.Sat, Jan 25, 2:33 AM

glebius added inline comments.Sat, Jan 25, 4:33 AM

usr.bin/genl/genl.c
295	This was some time ago. Today's style(9) actually explicitly allows to do that, which I love.

Remove the "nl" suffix from the Netlink family name. This is unneeded
tautology. You will see just "rpc" in the genl(1) output. Application
will lookup just "rpc" in the Netlink.

The Linux habit (and our new developing habit) us that Netlink families
are named with what they do, no "nl" prefixes or suffixes, except the
special "netlink control" family which is "nlctrl".

This revision now requires review to proceed.Fri, Jan 31, 11:19 PM

Harbormaster completed remote builds in B62186: Diff 150314.Fri, Jan 31, 11:19 PM

rmacklem accepted this revision.Sat, Feb 1, 12:04 AM

This revision is now accepted and ready to land.Sat, Feb 1, 12:04 AM

Closed by commit rG88cd1e17a7d8: genl: add RPC parser that dumps what sys/rpc/clnt_nl.c sends (authored by glebius). · Explain WhySat, Feb 1, 9:03 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG88cd1e17a7d8: genl: add RPC parser that dumps what sys/rpc/clnt_nl.c sends.