Page MenuHomeFreeBSD
Differential D48550

libc/rpc: add userland side RPC server over netlink(4)
ClosedPublic
Actions

Authored by glebius on Mon, Jan 20, 9:02 PM.
Tags
None
Referenced Files
F109267433: D48550.diff
Sun, Feb 2, 7:58 PM
Unknown Object (File)
Sat, Feb 1, 10:41 AM
Unknown Object (File)
Fri, Jan 31, 9:08 AM
Unknown Object (File)
Fri, Jan 31, 4:06 AM
Unknown Object (File)
Sun, Jan 26, 7:34 PM
Unknown Object (File)
Sun, Jan 26, 4:47 PM
Unknown Object (File)
Sat, Jan 25, 9:10 AM
Unknown Object (File)
Sat, Jan 25, 9:10 AM
View All 14 Files
Subscribers
imp
markj

Details

Reviewers
rmacklem
Group Reviewers
network
Commits
rGc5d671b711c3: libc/rpc: add userland side RPC server over netlink(4)
Summary

To be used by NFS related daemons that provide RPC services to the kernel.
Some implementation details inside the new svc_nl.c.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Mon, Jan 20, 9:02 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 20, 9:02 PM
glebius requested review of this revision.Mon, Jan 20, 9:02 PM
glebius added a parent revision: D48549: krpc: add kernel side client over netlink(4).
Harbormaster completed remote builds in B61823: Diff 149597.Mon, Jan 20, 9:02 PM
glebius added a child revision: D48551: genl: add RPC parser that dumps what sys/rpc/clnt_nl.c sends.Mon, Jan 20, 9:03 PM
glebius updated this revision to Diff 149620.Mon, Jan 20, 9:45 PM

Update with respect to committed changes and snl(3) as well as unstacked
changes to snl(3).

Harbormaster completed remote builds in B61845: Diff 149620.Mon, Jan 20, 9:46 PM
markj added a subscriber: markj.Fri, Jan 24, 4:22 PM
markj added inline comments.
lib/libc/rpc/Symbol.map
199

This should go in a new FBSD_1.8 version block, no? See lib/libc/Versions.def.

glebius updated this revision to Diff 149929.Fri, Jan 24, 5:07 PM

Address review.

Harbormaster completed remote builds in B62009: Diff 149929.Fri, Jan 24, 5:07 PM
glebius marked an inline comment as done.Fri, Jan 24, 5:09 PM
rmacklem added inline comments.Wed, Jan 29, 10:07 PM
lib/libc/rpc/svc_nl.c
89

SVCXPRT *xprt = NULL; so that it can be handled under fail:

126

svc_xprt_free(xprt); ?

glebius added inline comments.Wed, Jan 29, 11:25 PM
lib/libc/rpc/svc_nl.c
126

But there are no failures after svc_xprt_alloc()!

rmacklem accepted this revision.Wed, Jan 29, 11:37 PM
rmacklem added inline comments.
lib/libc/rpc/svc_nl.c
126

Yep. It might be a concern if someone adds an
additional failure point after this, but I suppose
it's ok to leave it as is.

This revision is now accepted and ready to land.Wed, Jan 29, 11:37 PM
glebius updated this revision to Diff 150313.Fri, Jan 31, 11:19 PM

Remove the "nl" suffix from the Netlink family name. This is unneeded
tautology. You will see just "rpc" in the genl(1) output. Application
will lookup just "rpc" in the Netlink.

The Linux habit (and our new developing habit) us that Netlink families
are named with what they do, no "nl" prefixes or suffixes, except the
special "netlink control" family which is "nlctrl".

This revision now requires review to proceed.Fri, Jan 31, 11:19 PM
Harbormaster completed remote builds in B62185: Diff 150313.Fri, Jan 31, 11:19 PM
rmacklem accepted this revision.Sat, Feb 1, 12:06 AM
This revision is now accepted and ready to land.Sat, Feb 1, 12:06 AM
Closed by commit rGc5d671b711c3: libc/rpc: add userland side RPC server over netlink(4) (authored by glebius). · Explain WhySat, Feb 1, 9:03 AM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGc5d671b711c3: libc/rpc: add userland side RPC server over netlink(4).

Revision Contents
Changeset List

PathSize
include/
rpc/
6 lines
lib/
libc/
rpc/
2 lines
4 lines
3 lines
300 lines

Diff 150342

View Options

include/rpc/svc.h

Loading...
View Options

lib/libc/rpc/Makefile.inc

Loading...
View Options

lib/libc/rpc/Symbol.map

Loading...
View Options

lib/libc/rpc/rpc_generic.c

Loading...
View Options

lib/libc/rpc/svc_nl.c

Loading...