Page MenuHomeFreeBSD

libc/rpc: add userland side RPC server over netlink(4)
ClosedPublic

Authored by glebius on Jan 20 2025, 9:02 PM.
Tags
None
Referenced Files
F115929144: D48550.diff
Wed, Apr 30, 1:12 PM
Unknown Object (File)
Sun, Apr 27, 4:50 AM
Unknown Object (File)
Wed, Apr 23, 8:38 PM
Unknown Object (File)
Wed, Apr 23, 8:59 AM
Unknown Object (File)
Wed, Apr 23, 8:53 AM
Unknown Object (File)
Wed, Apr 23, 8:46 AM
Unknown Object (File)
Wed, Apr 23, 8:38 AM
Unknown Object (File)
Wed, Apr 23, 8:37 AM
Subscribers

Details

Summary

To be used by NFS related daemons that provide RPC services to the kernel.
Some implementation details inside the new svc_nl.c.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62185
Build 59069: arc lint + arc unit

Event Timeline

Update with respect to committed changes and snl(3) as well as unstacked
changes to snl(3).

markj added inline comments.
lib/libc/rpc/Symbol.map
199

This should go in a new FBSD_1.8 version block, no? See lib/libc/Versions.def.

lib/libc/rpc/svc_nl.c
89

SVCXPRT *xprt = NULL; so that it can be handled under fail:

126

svc_xprt_free(xprt); ?

lib/libc/rpc/svc_nl.c
126

But there are no failures after svc_xprt_alloc()!

rmacklem added inline comments.
lib/libc/rpc/svc_nl.c
126

Yep. It might be a concern if someone adds an
additional failure point after this, but I suppose
it's ok to leave it as is.

This revision is now accepted and ready to land.Jan 29 2025, 11:37 PM

Remove the "nl" suffix from the Netlink family name. This is unneeded
tautology. You will see just "rpc" in the genl(1) output. Application
will lookup just "rpc" in the Netlink.

The Linux habit (and our new developing habit) us that Netlink families
are named with what they do, no "nl" prefixes or suffixes, except the
special "netlink control" family which is "nlctrl".

This revision now requires review to proceed.Jan 31 2025, 11:19 PM
This revision is now accepted and ready to land.Feb 1 2025, 12:06 AM