munmap.2: Unaligned addresses do not return error
ClosedPublic
Actions

Authored by emaste on Wed, Jan 15, 4:55 PM.

Details

Reviewers

kib
brooks

Commits

rG9e36aaf0c24c: munmap.2: Unaligned addresses do not return error

Summary

We previously claimed that non-page-aligned addresses would return
EINVAL, but the address is in fact rounded down to the page boundary.

Fixes: dabee6fecc67 ("kern_descrip.c: add fdshare()/fdcopy()")

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Turn reference into a link: rGdabee6fecc67

Hm, this used to be required by POSIX but newer versions allow the implementation not to treat that as an error

Ideally I'd like to see a note that the use of unaligned addresses is non-portable, but that's probably a separate commit.

This revision is now accepted and ready to land.Wed, Jan 15, 5:52 PM

Closed by commit rG9e36aaf0c24c: munmap.2: Unaligned addresses do not return error (authored by emaste). · Explain WhyWed, Jan 15, 6:11 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG9e36aaf0c24c: munmap.2: Unaligned addresses do not return error.

Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 15, 6:11 PM

Revision Contents
Changeset List

Path

Size

lib/

libsys/

munmap.2

4 lines

Diff 149294

View Options

munmap.2: Unaligned addresses do not return errorClosedPublicActions