Page MenuHomeFreeBSD

pci: Limit ASPM disable to ARM64
AbandonedPublic

Authored by kbowling on Tue, Jan 7, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 1:27 PM
Unknown Object (File)
Sat, Jan 11, 12:05 AM
Unknown Object (File)
Thu, Jan 9, 8:34 PM
Unknown Object (File)
Thu, Jan 9, 7:06 PM
Unknown Object (File)
Thu, Jan 9, 6:32 AM
Unknown Object (File)
Thu, Jan 9, 3:12 AM
Subscribers
None

Details

Reviewers
tuexen
jhb
imp
mav
andrew
Group Reviewers
arm64
Summary

ASPM can save double digit watts on NICs and other high end peripherals, it seems like a further ARM64 firmware investigation if these are getting disabled so limit the disable to that arch.

As a simple counterpoint, PHB4 on POWER9 supports ASPM and we'd want to support ASPM on any future PCIe implementations (RISC-V, etc) or know if there is some other issue at play.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kbowling created this revision.

We don't have any ASPM support so all this variable does is tell the ACPI code to lie to the firmware, and change what error code we return in the pci_disable_link_state fiunction in LinuxKPI.

@andrew got it, thanks for clarifying