Page MenuHomeFreeBSD

nv: Add <sys/_nv.h> header for nvlist_t declaration
ClosedPublic

Authored by jhb on Dec 28 2024, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 11:22 AM
Unknown Object (File)
Feb 19 2025, 8:25 PM
Unknown Object (File)
Feb 10 2025, 6:30 PM
Unknown Object (File)
Feb 4 2025, 5:32 AM
Unknown Object (File)
Jan 29 2025, 9:17 AM
Unknown Object (File)
Jan 25 2025, 1:23 PM
Unknown Object (File)
Jan 25 2025, 10:52 AM
Unknown Object (File)
Jan 21 2025, 3:18 PM
Subscribers
None

Details

Summary

This can be useful for headers that wish to use nvlist_t pointers in a
structure or function argument without pulling in all of the headers
from <sys/nv.h>.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Dec 28 2024, 9:15 PM
jhb created this revision.
sys/sys/cnv.h
40

Can't this be removed, here and elsewhere, since _nv.h includes it for !KERNEL and this is in !KERNEL?

One thing I did not try to address is the other places that define nvlist_t (notably in libcasper). They do so _after_ including <sys/nv.h> which is kind of confusing to me and I'm not sure why that is so I've left them alone.

sys/sys/cnv.h
40

Yes in theory. The reason I did not is that conceptually I just want <sys/_nv.h> to ensure that nvlist_t is defined. These headers define other symbols that <sys/nv_namespace.h> renames such as cnvlist_*, etc.

Ok. Those are good reasons.

This revision is now accepted and ready to land.Dec 30 2024, 5:54 PM