Page MenuHomeFreeBSD
Differential D48142

rtwn: refactor out the r92c path protection decision / configuration
Needs RevisionPublic
Actions

Authored by adrian on Thu, Dec 19, 3:40 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Jan 6, 9:26 AM
Unknown Object (File)
Fri, Dec 27, 9:46 AM
Unknown Object (File)
Thu, Dec 26, 7:25 AM
Unknown Object (File)
Thu, Dec 26, 2:37 AM
Unknown Object (File)
Thu, Dec 26, 2:19 AM
Unknown Object (File)
Wed, Dec 25, 11:48 AM
Unknown Object (File)
Tue, Dec 24, 10:52 PM
Unknown Object (File)
Sun, Dec 22, 8:18 PM
Subscribers
bz
fuz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Summary
  • refactor out the r92c path protection (RTS/CTS) decision
  • update the configuration code to ignore setting RTS/CTS for now if firmware rate control is enabled.

This works on RTL8192CU both with firmware rate control and driver
rate control. However, there is no RTS/CTS for firmware rate control -
the awareness will need to be added in a subsequent commit.

Locally tested:

  • RTL8192CU, STA - firmware and net80211 rate control

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61334
Build 58218: arc lint + arc unit

Event Timeline

adrian created this revision.Thu, Dec 19, 3:40 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Dec 19, 3:40 AM
adrian requested review of this revision.Thu, Dec 19, 3:40 AM
Harbormaster completed remote builds in B61257: Diff 148233.Thu, Dec 19, 3:40 AM
adrian added a parent revision: D48141: rtwn: refactor out datarate and short preamble setup.Thu, Dec 19, 3:41 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D48143: rtwn: allow firmware rate control to be enabled for rtl8192cu.
adrian updated this revision to Diff 148383.Wed, Dec 25, 2:35 AM

Implement rts/cts programming w/ firmware rate control config.

(This isn't enough by itself; the logic that SELECTS whether to do
rts/cts still needs updating.)

Harbormaster completed remote builds in B61325: Diff 148383.Wed, Dec 25, 2:35 AM
adrian updated this revision to Diff 148396.Thu, Dec 26, 5:38 AM

update with working protection mode logic for firmware rate control

Harbormaster completed remote builds in B61334: Diff 148396.Thu, Dec 26, 5:38 AM
fuz added a subscriber: fuz.Thu, Dec 26, 8:22 PM
fuz added inline comments.
sys/dev/rtwn/rtl8192c/r92c_tx.c
109–115

Avoid code duplication of the common ridx assignment.

317

Booleans should not be compared against true/false, use boolean operators instead.

329

This seems wrong. prot is unconditionally overwritten at this point. What is the point of the previous if statements? Is perhaps an else missing?

344

The control flow of this function is confusing and not obvious. Could you perhaps use an early return pattern instead of repeatedly assigning to prot?

bz requested changes to this revision.Tue, Jan 7, 6:58 PM
bz added a subscriber: bz.

@adrian, do you want to update according @fuz 's requests?

sys/dev/rtwn/rtl8192c/r92c_tx.c
109–115

? : go at he end of the line ; also there is an extra ; in there somewhere...

This revision now requires changes to proceed.Tue, Jan 7, 6:58 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8192c/
102 lines

Diff 148396

View Options

sys/dev/rtwn/rtl8192c/r92c_tx.c

Loading...