Page MenuHomeFreeBSD

rtwn: add placeholder fields for firmware rate control levels
Needs RevisionPublic

Authored by adrian on Dec 9 2024, 7:37 PM.
Referenced Files
Unknown Object (File)
Thu, Dec 26, 8:02 PM
Unknown Object (File)
Thu, Dec 26, 4:21 AM
Unknown Object (File)
Wed, Dec 25, 8:24 PM
Unknown Object (File)
Wed, Dec 25, 8:00 AM
Unknown Object (File)
Wed, Dec 25, 2:40 AM
Unknown Object (File)
Wed, Dec 18, 5:01 PM
Unknown Object (File)
Sat, Dec 14, 11:02 PM
Subscribers

Details

Reviewers
imp
bz
Group Reviewers
wireless
Summary

The RTL8192C (at least) firmware rate control behaviour seems to be
trying the highest configured rate first, and then trying slower rates
over time. It doesn't SEEM to be tracking it inside a given macid in
firmware - so if your rate mask says MCS15 is possible, but you're not
able to successfully transmit at it, the firmware will still keep
trying that every frame.

The vendor and Linux drivers work around this by looking at the RSSI
reports and constraining / expanding the ratemask for each macid.

This just adds the placeholder config field and rate masks; later
commits will set those and use those appropriately.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61055
Build 57939: arc lint + arc unit

Event Timeline

adrian requested review of this revision.Dec 9 2024, 7:37 PM
This revision is now accepted and ready to land.Thu, Dec 12, 6:10 PM
bz requested changes to this revision.Wed, Dec 18, 1:27 PM
bz added a subscriber: bz.

Please ignore my ignorance but can you point me at the review which will actually make use of these? I am lost in the stack...

This revision now requires changes to proceed.Wed, Dec 18, 1:28 PM

We can sit on this one and the next one in the stack and just continue reviewing/landing diffs above it until I get further along this stack and start using the dynamic rate adaption mask stuff.