kern: osd: trash a slot's methods upon deregistration
AcceptedPublic
Actions

Authored by kevans on Sat, Dec 14, 4:21 AM.

Details

Reviewers

markj
jamie
pjd
imp

Summary

This both lets us quickly identify a slot that's been deallocated while
debugging, and forces us to take a fault if something tries to call one
of the methods anyways somehow with osd_destructors[slot - 1] == NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61153
Build 58037: arc lint + arc unit

Event Timeline

kevans created this revision.Sat, Dec 14, 4:21 AM

Herald added subscribers: olce, imp. · View Herald TranscriptSat, Dec 14, 4:21 AM

kevans requested review of this revision.Sat, Dec 14, 4:21 AM

kevans added a parent revision: D48074: kern: osd: abstract away the math for locating a slot method.

Harbormaster completed remote builds in B61153: Diff 147948.Sat, Dec 14, 4:21 AM

jamie mentioned this in D48074: kern: osd: abstract away the math for locating a slot method.Sat, Dec 14, 4:44 AM

imp accepted this revision.Sat, Dec 14, 4:45 AM

This revision is now accepted and ready to land.Sat, Dec 14, 4:45 AM

Accepted with the caveat I mentioned in D48074.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_osd.c

12 lines

Diff 147948

View Options

kern: osd: trash a slot's methods upon deregistrationAcceptedPublicActions