distributeworld: dedup dist(.debug).meta generation
ClosedPublic
Actions

Authored by brooks on Dec 11 2024, 8:49 PM.

Details

Reviewers

emaste

Commits

rG7d0d52fc7c53: distributeworld: dedup dist(.debug).meta generation

Summary

Debug file distribution metadata generation was added in 2d0bcb76c8530
as a near duplicate of the default distribution bits. Add another loop
instead of copying the code. While here, improve indentation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 61094
Build 57978: arc lint + arc unit

Event Timeline

brooks created this revision.Dec 11 2024, 8:49 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2024, 8:49 PM

brooks requested review of this revision.Dec 11 2024, 8:49 PM

Harbormaster completed remote builds in B61094: Diff 147831.Dec 11 2024, 8:49 PM

emaste added a subscriber: guest-patmaddox.Dec 11 2024, 8:53 PM

At first I wondered if this change would result in the .debug files being included both foo.meta and foo.debug.meta, but then I see that this is already the case before this change.

$ grep true.debug base*meta
base.debug.meta:./usr/lib/debug/usr/bin/true.debug type=file uname=root gname=wheel mode=0444 size=6408 tags=package=utilities,dbg
base.meta:./usr/lib/debug/usr/bin/true.debug type=file uname=root gname=wheel mode=0444 size=6408 tags=package=utilities,dbg

but we exclude the debug files in packageworld via --exclude usr/lib/debug

emaste accepted this revision.Dec 12 2024, 1:31 AM

This revision is now accepted and ready to land.Dec 12 2024, 1:31 AM

Closed by commit rG7d0d52fc7c53: distributeworld: dedup dist(.debug).meta generation (authored by brooks). · Explain WhyDec 12 2024, 4:30 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG7d0d52fc7c53: distributeworld: dedup dist(.debug).meta generation.