Differential D47980

lindebugfs: Export symbols
ClosedPublic
Actions

Authored by emaste on Dec 7 2024, 6:23 PM.

Tags

None

Referenced Files

	F107378983: D47980.diff
	Mon, Jan 13, 7:36 AM

	Unknown Object (File)
	Sat, Jan 11, 4:12 AM

	Unknown Object (File)
	Tue, Jan 7, 6:52 PM

	Unknown Object (File)
	Dec 11 2024, 4:42 AM

	Unknown Object (File)
	Dec 8 2024, 1:24 AM

Subscribers

Details

Reviewers

kib
bz

Commits

rG96ef85cc51ba: lindebugfs: Export symbols
rGc3d2c959b5c0: lindebugfs: Export symbols

Summary

We currently rely on the kernel linker resolving undefined references against local symbols from other kernel modules. Be explicit about the symbols to export, in advance of changing that behaviour.

PR: 207898

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Dec 7 2024, 6:23 PM

emaste created this revision.

kib accepted this revision.Dec 7 2024, 11:26 PM

This revision is now accepted and ready to land.Dec 7 2024, 11:26 PM

I tried to see if this is all I found in the header file; I wonder if we should also sort the header file to the same order so it's easier to see ;-)
Found one which I couldn't spot above.

sys/modules/lindebugfs/Makefile
11	debugfs_create_blob

This revision now requires changes to proceed.Dec 7 2024, 11:46 PM

add missing symbol found by @bz

bz accepted this revision.Dec 8 2024, 12:43 AM

This revision is now accepted and ready to land.Dec 8 2024, 12:43 AM

Closed by commit rGc3d2c959b5c0: lindebugfs: Export symbols (authored by emaste). · Explain WhyDec 8 2024, 1:25 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGc3d2c959b5c0: lindebugfs: Export symbols.

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2024, 1:25 AM

emaste added a commit: rG96ef85cc51ba: lindebugfs: Export symbols.Tue, Jan 7, 6:49 PM

Revision Contents
Changeset List

Path

Size

sys/

modules/

lindebugfs/

21 lines

Diff 147689

sys/modules/lindebugfs/Makefile

Loading...