Use bus_generic_detach instead of device_delete_children in detach
Needs ReviewPublic
Actions

Authored by jhb on Fri, Dec 6, 10:31 PM.

Details

Reviewers

imp
andrew

Summary

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61010
Build 57894: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Dec 6, 10:31 PM

Herald added a reviewer: andrew. · View Herald TranscriptFri, Dec 6, 10:31 PM

jhb requested review of this revision.Fri, Dec 6, 10:31 PM

jhb added a parent revision: D47968: bhnd bcma/siba: Remove duplicate call to device_delete_children.

Harbormaster completed remote builds in B61010: Diff 147647.Fri, Dec 6, 10:31 PM

jhb added a child revision: D47970: etherswitch: Cleanup detach and delete of child devices during detach.Fri, Dec 6, 10:31 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

freescale/

vybrid/

vf_ehci.c

2 lines

mv/

a37x0_spi.c

2 lines

nvidia/

tegra_ehci.c

10 lines

tegra_xhci.c

6 lines

ti/

am335x/

am335x_musb.c

5 lines

usb/

omap_ehci.c

4 lines

omap_host.c

5 lines

xilinx/

zy7_ehci.c

5 lines

dev/

ahci/

ahci.c

6 lines

ata/

ata-pci.c

5 lines

atopcase/

atopcase.c

2 lines

etherswitch/

e6000sw/

e6000sw.c

8 lines

hyperv/

input/

hv_hid.c

2 lines

iicbus/

iicbus.c

2 lines

iichid.c

2 lines

intel/

spi.c

7 lines

mmc/

host/

dwmmc.c

2 lines

mvs/

mvs_pci.c

5 lines

mvs_soc.c

5 lines

neta/

if_mvneta.c

2 lines

ow/

owc_gpiobus.c

2 lines

p2sb/

p2sb.c

6 lines

ppc/

ppc.c

5 lines

rtsx/

rtsx.c

6 lines

siis/

siis.c

5 lines

sound/

pci/

hda/

2 lines

2 lines

2 lines

2 lines

spibus/

spibus.c

2 lines

usb/

controller/

5 lines

5 lines

14 lines

2 lines

10 lines

4 lines

5 lines

4 lines

4 lines

4 lines

13 lines

5 lines

5 lines

5 lines

input/

usbhid.c

6 lines

video/

udl.c

5 lines

Diff 147647

View Options

sys/arm/freescale/vybrid/vf_ehci.c

View Options

sys/arm/mv/a37x0_spi.c

View Options

sys/arm/nvidia/tegra_ehci.c

View Options

sys/arm/nvidia/tegra_xhci.c

View Options

sys/arm/ti/am335x/am335x_musb.c

View Options

sys/arm/ti/usb/omap_ehci.c

View Options

sys/arm/ti/usb/omap_host.c

View Options

sys/arm/xilinx/zy7_ehci.c

View Options

sys/dev/ahci/ahci.c

View Options

sys/dev/ata/ata-pci.c

View Options

sys/dev/atopcase/atopcase.c

View Options

sys/dev/etherswitch/e6000sw/e6000sw.c

View Options

sys/dev/hyperv/input/hv_hid.c

View Options

sys/dev/iicbus/iicbus.c

View Options

sys/dev/iicbus/iichid.c

View Options

sys/dev/intel/spi.c

View Options

sys/dev/mmc/host/dwmmc.c

View Options

sys/dev/mvs/mvs_pci.c

View Options

sys/dev/mvs/mvs_soc.c

View Options

sys/dev/neta/if_mvneta.c

View Options

sys/dev/ow/owc_gpiobus.c

View Options

sys/dev/p2sb/p2sb.c

View Options

sys/dev/ppc/ppc.c

View Options

sys/dev/rtsx/rtsx.c

View Options

sys/dev/siis/siis.c

View Options

sys/dev/sound/pci/hda/hdaa.c

View Options

sys/dev/sound/pci/hda/hdacc.c

View Options

sys/dev/sound/pci/hdsp.c

View Options

sys/dev/sound/pci/hdspe.c

View Options

sys/dev/spibus/spibus.c

View Options

sys/dev/usb/controller/dwc_otg_acpi.c

View Options

sys/dev/usb/controller/dwc_otg_fdt.c

View Options

sys/dev/usb/controller/ehci_fsl.c

View Options

sys/dev/usb/controller/ehci_imx.c

View Options

sys/dev/usb/controller/ehci_msm.c

View Options

sys/dev/usb/controller/ehci_mv.c

View Options

sys/dev/usb/controller/ehci_pci.c

View Options

sys/dev/usb/controller/generic_ehci.c

View Options

sys/dev/usb/controller/generic_ohci.c

View Options

sys/dev/usb/controller/generic_xhci.c

View Options

sys/dev/usb/controller/musb_otg_allwinner.c

View Options

sys/dev/usb/controller/ohci_pci.c

View Options

sys/dev/usb/controller/uhci_pci.c

View Options

sys/dev/usb/controller/xhci_pci.c

View Options

sys/dev/usb/input/usbhid.c

View Options

Use bus_generic_detach instead of device_delete_children in detachNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 147647

sys/arm/freescale/vybrid/vf_ehci.c

sys/arm/mv/a37x0_spi.c

sys/arm/nvidia/tegra_ehci.c

sys/arm/nvidia/tegra_xhci.c

sys/arm/ti/am335x/am335x_musb.c

sys/arm/ti/usb/omap_ehci.c

sys/arm/ti/usb/omap_host.c

sys/arm/xilinx/zy7_ehci.c

sys/dev/ahci/ahci.c

sys/dev/ata/ata-pci.c

sys/dev/atopcase/atopcase.c

sys/dev/etherswitch/e6000sw/e6000sw.c

sys/dev/hyperv/input/hv_hid.c

sys/dev/iicbus/iicbus.c

sys/dev/iicbus/iichid.c

sys/dev/intel/spi.c

sys/dev/mmc/host/dwmmc.c

sys/dev/mvs/mvs_pci.c

sys/dev/mvs/mvs_soc.c

sys/dev/neta/if_mvneta.c

sys/dev/ow/owc_gpiobus.c

sys/dev/p2sb/p2sb.c

sys/dev/ppc/ppc.c

sys/dev/rtsx/rtsx.c

sys/dev/siis/siis.c

sys/dev/sound/pci/hda/hdaa.c

sys/dev/sound/pci/hda/hdacc.c

sys/dev/sound/pci/hdsp.c

sys/dev/sound/pci/hdspe.c

sys/dev/spibus/spibus.c

sys/dev/usb/controller/dwc_otg_acpi.c

sys/dev/usb/controller/dwc_otg_fdt.c

sys/dev/usb/controller/ehci_fsl.c

sys/dev/usb/controller/ehci_imx.c

sys/dev/usb/controller/ehci_msm.c

sys/dev/usb/controller/ehci_mv.c

sys/dev/usb/controller/ehci_pci.c

sys/dev/usb/controller/generic_ehci.c

sys/dev/usb/controller/generic_ohci.c

sys/dev/usb/controller/generic_xhci.c

sys/dev/usb/controller/musb_otg_allwinner.c

sys/dev/usb/controller/ohci_pci.c

sys/dev/usb/controller/uhci_pci.c

sys/dev/usb/controller/xhci_pci.c

sys/dev/usb/input/usbhid.c

sys/dev/usb/video/udl.c

Use bus_generic_detach instead of device_delete_children in detach
Needs ReviewPublic
Actions

Revision Contents
Changeset List